Skip to content

[SPARK-15613] set correct TimeZone in test cases "to UTC timestamp" and "from UTC t… #13785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ckadner wants to merge 1 commit into from
Closed

[SPARK-15613] set correct TimeZone in test cases "to UTC timestamp" and "from UTC t… #13785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
set correct TimeZone in test cases "to UTC timestamp" and "from UTC t… 
…imestamp"
  • Loading branch information
@ckadner
ckadner committed Jun 20, 2016
commit 66254e0030451de43339753df12191776a0809a3
14 changes: 9 additions & 5 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,8 +485,10 @@ class DateTimeUtilsSuite extends SparkFunSuite {

test("from UTC timestamp") {
def test(utc: String, tz: String, expected: String): Unit = {
assert(toJavaTimestamp(fromUTCTime(fromJavaTimestamp(Timestamp.valueOf(utc)), tz)).toString
=== expected)
DateTimeTestUtils.withDefaultTimeZone(TimeZone.getTimeZone("UTC")) {
assert(toJavaTimestamp(fromUTCTime(fromJavaTimestamp(Timestamp.valueOf(utc)), tz)).toString
=== expected)
}
}
test("2011-12-25 09:00:00.123456", "UTC", "2011-12-25 09:00:00.123456")
test("2011-12-25 09:00:00.123456", "JST", "2011-12-25 18:00:00.123456")
Expand All @@ -502,9 +504,11 @@ class DateTimeUtilsSuite extends SparkFunSuite {
}

test("to UTC timestamp") {
def test(utc: String, tz: String, expected: String): Unit = {
assert(toJavaTimestamp(toUTCTime(fromJavaTimestamp(Timestamp.valueOf(utc)), tz)).toString
=== expected)
def test(ts: String, tz: String, expected: String): Unit = {
DateTimeTestUtils.withDefaultTimeZone(TimeZone.getTimeZone(tz)) {
assert(toJavaTimestamp(toUTCTime(fromJavaTimestamp(Timestamp.valueOf(ts)), tz)).toString
=== expected)
}
}
test("2011-12-25 09:00:00.123456", "UTC", "2011-12-25 09:00:00.123456")
test("2011-12-25 18:00:00.123456", "JST", "2011-12-25 09:00:00.123456")
Expand Down