Skip to content

Conversation

@davies
Copy link
Contributor

@davies davies commented Jun 20, 2016

What changes were proposed in this pull request?

Fix the bug for Python UDF that does not have any arguments.

How was this patch tested?

Added regression tests.

@SparkQA
Copy link

SparkQA commented Jun 20, 2016

Test build #60889 has finished for PR 13793 at commit 7d7fec7.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@davies davies force-pushed the fix_no_arguments branch from 7d7fec7 to 4e92173 Compare June 21, 2016 00:10
@SparkQA
Copy link

SparkQA commented Jun 21, 2016

Test build #60891 has finished for PR 13793 at commit 4e92173.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member

looks good!

asfgit pushed a commit that referenced this pull request Jun 21, 2016
## What changes were proposed in this pull request?

Fix the bug for Python UDF that does not have any arguments.

## How was this patch tested?

Added regression tests.

Author: Davies Liu <[email protected]>

Closes #13793 from davies/fix_no_arguments.
asfgit pushed a commit that referenced this pull request Jun 21, 2016
## What changes were proposed in this pull request?

Fix the bug for Python UDF that does not have any arguments.

## How was this patch tested?

Added regression tests.

Author: Davies Liu <[email protected]>

Closes #13793 from davies/fix_no_arguments.

(cherry picked from commit abe36c5)
Signed-off-by: Davies Liu <[email protected]>
asfgit pushed a commit that referenced this pull request Jun 21, 2016
Fix the bug for Python UDF that does not have any arguments.

Added regression tests.

Author: Davies Liu <[email protected]>

Closes #13793 from davies/fix_no_arguments.

(cherry picked from commit abe36c5)
Signed-off-by: Davies Liu <[email protected]>
@davies
Copy link
Contributor Author

davies commented Jun 21, 2016

Merged into 1.5, 1.6, 2.0 and master.

@davies davies closed this Jun 21, 2016
asfgit pushed a commit that referenced this pull request Jun 21, 2016
Fix the bug for Python UDF that does not have any arguments.

Added regression tests.

Author: Davies Liu <[email protected]>

Closes #13793 from davies/fix_no_arguments.

(cherry picked from commit abe36c5)
Signed-off-by: Davies Liu <[email protected]>
zzcclp pushed a commit to zzcclp/spark that referenced this pull request Jun 21, 2016
## What changes were proposed in this pull request?

Fix the bug for Python UDF that does not have any arguments.

## How was this patch tested?

Added regression tests.

Author: Davies Liu <[email protected]>

Closes apache#13793 from davies/fix_no_arguments.

(cherry picked from commit abe36c5)
@mengxr
Copy link
Contributor

mengxr commented Jun 21, 2016

@davies The PR was sent to branch-1.6 and Jenkins didn't run it for branch-2.0 and master. Does it apply to branch-2.0 and master? Master seems broken by this PR: https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test/job/spark-master-test-sbt-hadoop-2.2/1212/consoleFull

@mengxr
Copy link
Contributor

mengxr commented Jun 21, 2016

I reverted the changes in branch-2.0 and master and updated the JIRA. Please re-submit PRs to branch-2.0 and master if they need fixes.

@davies
Copy link
Contributor Author

davies commented Jun 21, 2016

@mengxr My bad, 2.0 and master does not have this bug, but still good to have the test and change, I will send a new PR to fix the conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants