[SPARK-13792][SQL] Limit logging of bad records in CSV data source #13795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @maropu |
| } | ||
| } | ||
|
|
||
| def parseCsv( |
Member
|
@rxin okay, lgtm. |
|
Test build #60896 has finished for PR 13795 at commit
|
Contributor
Author
|
Merging in master/2.0. |
asfgit
pushed a commit
that referenced
this pull request
Jun 21, 2016
## What changes were proposed in this pull request? This pull request adds a new option (maxMalformedLogPerPartition) in CSV reader to limit the maximum of logging message Spark generates per partition for malformed records. The error log looks something like ``` 16/06/20 18:50:14 WARN CSVRelation: Dropping malformed line: adsf,1,4 16/06/20 18:50:14 WARN CSVRelation: Dropping malformed line: adsf,1,4 16/06/20 18:50:14 WARN CSVRelation: Dropping malformed line: adsf,1,4 16/06/20 18:50:14 WARN CSVRelation: Dropping malformed line: adsf,1,4 16/06/20 18:50:14 WARN CSVRelation: Dropping malformed line: adsf,1,4 16/06/20 18:50:14 WARN CSVRelation: Dropping malformed line: adsf,1,4 16/06/20 18:50:14 WARN CSVRelation: Dropping malformed line: adsf,1,4 16/06/20 18:50:14 WARN CSVRelation: Dropping malformed line: adsf,1,4 16/06/20 18:50:14 WARN CSVRelation: Dropping malformed line: adsf,1,4 16/06/20 18:50:14 WARN CSVRelation: Dropping malformed line: adsf,1,4 16/06/20 18:50:14 WARN CSVRelation: More than 10 malformed records have been found on this partition. Malformed records from now on will not be logged. ``` Closes #12173 ## How was this patch tested? Manually tested. Author: Reynold Xin <[email protected]> Closes #13795 from rxin/SPARK-13792. (cherry picked from commit c775bf0) Signed-off-by: Reynold Xin <[email protected]>
| log for each partition. Malformed records beyond this | ||
| number will be ignored. If None is set, it | ||
| uses the default value, ``10``. | ||
| :param mode: allows a mode for dealing with corrupt records during parsing. If None is |
Member
There was a problem hiding this comment.
doesn't this maxMalformedLogPerPartition need to be added to L412, self._set_csv_opts?
Contributor
Author
There was a problem hiding this comment.
Actually this is right!
asfgit
pushed a commit
that referenced
this pull request
Jun 21, 2016
## What changes were proposed in this pull request? This is a follow-up to #13795 to properly set CSV options in Python API. As part of this, I also make the Python option setting for both CSV and JSON more robust against positional errors. ## How was this patch tested? N/A Author: Reynold Xin <[email protected]> Closes #13800 from rxin/SPARK-13792-2. (cherry picked from commit 9333880) Signed-off-by: Reynold Xin <[email protected]>
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Jun 21, 2016
## What changes were proposed in this pull request? This is a follow-up to apache#13795 to properly set CSV options in Python API. As part of this, I also make the Python option setting for both CSV and JSON more robust against positional errors. ## How was this patch tested? N/A Author: Reynold Xin <[email protected]> Closes apache#13800 from rxin/SPARK-13792-2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pull request adds a new option (maxMalformedLogPerPartition) in CSV reader to limit the maximum of logging message Spark generates per partition for malformed records.
The error log looks something like
Closes #12173
How was this patch tested?
Manually tested.