Skip to content

[SPARK-13023][PROJECT INFRA][FOLLOWUP][BRANCH-1.6] Unable to check root module ending up failure of Python tests #13845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 2 commits into from
Closed

[SPARK-13023][PROJECT INFRA][FOLLOWUP][BRANCH-1.6] Unable to check root module ending up failure of Python tests #13845

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84ad679
Check modules to test correctly
HyukjinKwon Jun 22, 2016
6e72652
Fix comments
HyukjinKwon Jun 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Check modules to test correctly
  • Loading branch information
@HyukjinKwon
HyukjinKwon committed Jun 22, 2016
commit 84ad6797d22966c04f07cb71afe8369dc25cafb3
3 changes: 2 additions & 1 deletion dev/run-tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,10 @@ def determine_modules_to_test(changed_modules):
for module in changed_modules:
modules_to_test = modules_to_test.union(determine_modules_to_test(module.dependent_modules))
# If we need to run all of the tests, then we should short-circuit and return 'root'
modules_to_test = modules_to_test.union(set(changed_modules))
if modules.root in modules_to_test:
return [modules.root]
return modules_to_test.union(set(changed_modules))
return modules_to_test


def determine_tags_to_exclude(changed_modules):
Expand Down