[SPARK-16241] [ML] model loading backward compatibility for ml NaiveBayes #13940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zlpmichelle
changed the title
Contributor
|
LGTM. |
Contributor
Author
|
Thanks @hhbyyh @AmplabJenkins! |
Contributor
|
Jenkins, test this please. |
Contributor
|
ok to test |
|
Test build #61440 has finished for PR 13940 at commit
|
| import org.apache.spark.mllib.util.MLUtils | ||
| import org.apache.spark.rdd.RDD | ||
| import org.apache.spark.sql.Dataset | ||
| import org.apache.spark.sql.{Row, Dataset} |
Contributor
There was a problem hiding this comment.
Notice the import order, it should be import org.apache.spark.sql.{Dataset, Row}
Contributor
Author
|
Fixed it. Thanks @yanboliang for your nice review. |
|
Test build #61458 has finished for PR 13940 at commit
|
Contributor
Author
|
The patch passed all tests. Thanks very much @mengxr ! |
Contributor
|
LGTM, merged into master and branch-2.0. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Jun 30, 2016
## What changes were proposed in this pull request? model loading backward compatibility for ml NaiveBayes ## How was this patch tested? existing ut and manual test for loading models saved by Spark 1.6. Author: zlpmichelle <[email protected]> Closes #13940 from zlpmichelle/naivebayes. (cherry picked from commit b30a2dc) Signed-off-by: Yanbo Liang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
model loading backward compatibility for ml NaiveBayes
How was this patch tested?
existing ut and manual test for loading models saved by Spark 1.6.