Skip to content

[SPARK-16278][SPARK-16279][SQL] Implement map_keys/map_values SQL functions #13967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 4 commits into from
Closed

[SPARK-16278][SPARK-16279][SQL] Implement map_keys/map_values SQL functions #13967

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a639bc
[SPARK-16278][SPARK-16279][SQL] Implement map_keys/map_values SQL fun…
dongjoon-hyun Jun 29, 2016
8c1ea5b
Remove redundant copy() and add function extended description.
dongjoon-hyun Jun 30, 2016
c0dac4b
Add a null map testcase and remove redundant implementation.
dongjoon-hyun Jun 30, 2016
8db1e65
Remove from `sql.functions`.
dongjoon-hyun Jul 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a null map testcase and remove redundant implementation.
  • Loading branch information
@dongjoon-hyun
dongjoon-hyun committed Jul 2, 2016
commit c0dac4bacbd07d244ea716db076b7a638be31837
4 changes: 0 additions & 4 deletions ...alyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@ case class MapKeys(child: Expression)

override def dataType: DataType = ArrayType(child.dataType.asInstanceOf[MapType].keyType)

override def foldable: Boolean = child.foldable

override def nullSafeEval(map: Any): Any = {
map.asInstanceOf[MapData].keyArray()
}
Expand All @@ -82,8 +80,6 @@ case class MapValues(child: Expression)

override def dataType: DataType = ArrayType(child.dataType.asInstanceOf[MapType].valueType)

override def foldable: Boolean = child.foldable

override def nullSafeEval(map: Any): Any = {
map.asInstanceOf[MapData].valueArray()
}
Expand Down
3 changes: 3 additions & 0 deletions ...t/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionFunctionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,14 @@ class CollectionFunctionsSuite extends SparkFunSuite with ExpressionEvalHelper {
test("MapKeys/MapValues") {
val m0 = Literal.create(Map("a" -> "1", "b" -> "2"), MapType(StringType, StringType))
val m1 = Literal.create(Map[String, String](), MapType(StringType, StringType))
val m2 = Literal.create(null, MapType(StringType, StringType))

checkEvaluation(MapKeys(m0), Seq("a", "b"))
checkEvaluation(MapValues(m0), Seq("1", "2"))
checkEvaluation(MapKeys(m1), Seq())
checkEvaluation(MapValues(m1), Seq())
checkEvaluation(MapKeys(m2), null)
checkEvaluation(MapValues(m2), null)
}

test("Sort Array") {
Expand Down