[SPARK-16291][SQL] CheckAnalysis should capture nested aggregate functions that reference no input attributes #13968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
…e no input attributes.
liancheng
force-pushed
the
spark-16291-nested-agg-functions
branch
from
18e7485 to
9a1f711
Compare
|
Test build #61456 has finished for PR 13968 at commit
|
Contributor
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Jun 29, 2016
…tions that reference no input attributes ## What changes were proposed in this pull request? `MAX(COUNT(*))` is invalid since aggregate expression can't be nested within another aggregate expression. This case should be captured at analysis phase, but somehow sneaks off to runtime. The reason is that when checking aggregate expressions in `CheckAnalysis`, a checking branch treats all expressions that reference no input attributes as valid ones. However, `MAX(COUNT(*))` is translated into `MAX(COUNT(1))` at analysis phase and also references no input attribute. This PR fixes this issue by removing the aforementioned branch. ## How was this patch tested? New test case added in `AnalysisErrorSuite`. Author: Cheng Lian <[email protected]> Closes #13968 from liancheng/spark-16291-nested-agg-functions. (cherry picked from commit d1e8108) Signed-off-by: Wenchen Fan <[email protected]>
Contributor
|
merging to master/2.0 |
|
Test build #61457 has finished for PR 13968 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
MAX(COUNT(*))is invalid since aggregate expression can't be nested within another aggregate expression. This case should be captured at analysis phase, but somehow sneaks off to runtime.The reason is that when checking aggregate expressions in
CheckAnalysis, a checking branch treats all expressions that reference no input attributes as valid ones. However,MAX(COUNT(*))is translated intoMAX(COUNT(1))at analysis phase and also references no input attribute.This PR fixes this issue by removing the aforementioned branch.
How was this patch tested?
New test case added in
AnalysisErrorSuite.