-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-16289][SQL] Implement posexplode table generating function #13971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
584eb9e
[SPARK-16289][SQL] Implement posexplode table generating function
dongjoon-hyun fcfccee
Add function descs, examples in comments, and indentation.
dongjoon-hyun e255873
Add GeneratorSuite.
dongjoon-hyun 1cf723a
Add empty array cases.
dongjoon-hyun c5dee49
Make sql.GeneratorSuite and move the existing testcases.
dongjoon-hyun 153e8eb
Rename.
dongjoon-hyun 0266052
Add posexplode to python
dongjoon-hyun 5f3a951
Add posexplode to R.
dongjoon-hyun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add GeneratorSuite.
- Loading branch information
commit e2558733e62b17da02035a504788d775abbf32ab
There are no files selected for viewing
63 changes: 63 additions & 0 deletions
63
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/GeneratorSuite.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.catalyst.expressions | ||
|
|
||
| import org.apache.spark.SparkFunSuite | ||
| import org.apache.spark.sql.catalyst.InternalRow | ||
| import org.apache.spark.unsafe.types.UTF8String | ||
|
|
||
| class GeneratorSuite extends SparkFunSuite with ExpressionEvalHelper { | ||
| private def checkTuple(actual: ExplodeBase, expected: Seq[InternalRow]): Unit = { | ||
| assert(actual.eval(null).toSeq === expected) | ||
| } | ||
|
|
||
| private final val int_array = Seq(1, 2, 3) | ||
| private final val str_array = Seq("a", "b", "c") | ||
|
|
||
| test("explode") { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you add a test case for empty input?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep. Done. |
||
| val int_correct_answer = Seq(Seq(1), Seq(2), Seq(3)) | ||
| val str_correct_answer = Seq( | ||
| Seq(UTF8String.fromString("a")), | ||
| Seq(UTF8String.fromString("b")), | ||
| Seq(UTF8String.fromString("c"))) | ||
|
|
||
| checkTuple( | ||
| Explode(CreateArray(int_array.map(Literal(_)))), | ||
| int_correct_answer.map(InternalRow.fromSeq(_))) | ||
|
|
||
| checkTuple( | ||
| Explode(CreateArray(str_array.map(Literal(_)))), | ||
| str_correct_answer.map(InternalRow.fromSeq(_))) | ||
| } | ||
|
|
||
| test("posexplode") { | ||
| val int_correct_answer = Seq(Seq(0, 1), Seq(1, 2), Seq(2, 3)) | ||
| val str_correct_answer = Seq( | ||
| Seq(0, UTF8String.fromString("a")), | ||
| Seq(1, UTF8String.fromString("b")), | ||
| Seq(2, UTF8String.fromString("c"))) | ||
|
|
||
| checkTuple( | ||
| PosExplode(CreateArray(int_array.map(Literal(_)))), | ||
| int_correct_answer.map(InternalRow.fromSeq(_))) | ||
|
|
||
| checkTuple( | ||
| PosExplode(CreateArray(str_array.map(Literal(_)))), | ||
| str_correct_answer.map(InternalRow.fromSeq(_))) | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thsi one maybe GeneratorExpressionSuite