[SPARK-16301] [SQL] The analyzer rule for resolving using joins should respect the case sensitivity setting. #13977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d respect the case sensitivity setting.
| right: LogicalPlan, | ||
| joinType: JoinType, | ||
| joinNames: Seq[String], | ||
| condition: Option[Expression]) = { |
Contributor
Author
There was a problem hiding this comment.
These 5 lines are just formatting changes.
Contributor
|
Just a single comment, otherwise LGTM. Thanks for addressing this so quickly! |
|
Test build #61485 has finished for PR 13977 at commit
|
|
Test build #61483 has finished for PR 13977 at commit
|
Contributor
|
LGTM, |
asfgit
pushed a commit
that referenced
this pull request
Jun 29, 2016
…d respect the case sensitivity setting. ## What changes were proposed in this pull request? The analyzer rule for resolving using joins should respect the case sensitivity setting. ## How was this patch tested? New tests in ResolveNaturalJoinSuite Author: Yin Huai <[email protected]> Closes #13977 from yhuai/SPARK-16301. (cherry picked from commit 8b5a8b2) Signed-off-by: Davies Liu <[email protected]>
|
Test build #61491 has finished for PR 13977 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The analyzer rule for resolving using joins should respect the case sensitivity setting.
How was this patch tested?
New tests in ResolveNaturalJoinSuite