Skip to content

[SPARK-12177][Streaming][Kafka] limit api surface area #13998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
koeninger wants to merge 10 commits into from
Closed

[SPARK-12177][Streaming][Kafka] limit api surface area #13998

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2cf8fad
[SPARK-12177][Streaming][Kafka] limit LocationStrategy api surface area
koeninger Jun 30, 2016
27d6337
[SPARK-12177][Streaming][Kafka] limit ConsumerStrategy api surface area
koeninger Jun 30, 2016
205536a
[SPARK-12177][Streaming][Kafka] capitalize static methods to make the…
koeninger Jun 30, 2016
ef040cf
[SPARK-12177][Streaming][Kafka] more separation of java long from sca…
koeninger Jun 30, 2016
b442c98
[SPARK-12177][Streaming][Kafka] fix scalastyle
koeninger Jun 30, 2016
2aea113
[SPARK-12177][Streaming][Kafka] tweak default timeout to see if it in…
koeninger Jun 30, 2016
2652170
[SPARK-12177][Streaming][Kafka] move trait to abstract class per tdas
koeninger Jun 30, 2016
d1480e7
[SPARK-12177][Streaming][Kafka] add doc link
koeninger Jul 1, 2016
22db76f
[SPARK-12177][Streaming][Kafka] fix package object name and doc links
koeninger Jul 1, 2016
2f65fc1
[SPARK-12177][Streaming][Kafka] use a random port for embedded Kafka
koeninger Jul 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[SPARK-12177][Streaming][Kafka] move trait to abstract class per tdas
  • Loading branch information
@koeninger
koeninger committed Jun 30, 2016
commit 2652170916114965ac72ec75abfc6772b54b43e8
2 changes: 1 addition & 1 deletion ...rnal/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/ConsumerStrategy.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import org.apache.spark.annotation.Experimental
* @tparam V type of Kafka message value
*/
@Experimental
trait ConsumerStrategy[K, V] {
abstract class ConsumerStrategy[K, V] {
Copy link
Contributor

@tdas tdas Jun 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a pointer to the ConsumerStrategies class in the docs for this class?

And similarly for LocationStrategies?

/**
* Kafka <a href="http://kafka.apache.org/documentation.htmll#newconsumerconfigs">
* configuration parameters</a> to be used on executors. Requires "bootstrap.servers" to be set
Expand Down
2 changes: 1 addition & 1 deletion ...rnal/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/LocationStrategy.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import org.apache.spark.annotation.Experimental
* Choice of location is only a preference, not an absolute; partitions may be scheduled elsewhere.
*/
@Experimental
sealed trait LocationStrategy
sealed abstract class LocationStrategy

private case object PreferBrokers extends LocationStrategy

Expand Down