Skip to content

[SPARK-16406][SQL] Improve performance of LogicalPlan.resolve #14083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hvanhovell wants to merge 11 commits into from
Closed

[SPARK-16406][SQL] Improve performance of LogicalPlan.resolve #14083

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b4c8cdb
Add AttributeResolver
hvanhovell Jul 6, 2016
a8a6a83
Merge remote-tracking branch 'apache-github/master' into SPARK-16406
hvanhovell Jul 7, 2016
3e39720
move refresh back
hvanhovell Jul 7, 2016
c75ae8d
Use Seq-based instead of List-based pattern matching
hvanhovell Jul 7, 2016
a5d1a4a
Rename attribute after resolution.
hvanhovell Jul 8, 2016
d64346b
Move resolution into AttribueSeq
hvanhovell Sep 11, 2016
a1e5312
Merge remote-tracking branch 'apache-github/master' into SPARK-16406
hvanhovell Sep 11, 2016
85e0744
Merge remote-tracking branch 'apache/master' into SPARK-16406
hvanhovell Apr 20, 2018
eb6dd80
Fix compilation
hvanhovell Apr 20, 2018
ac4abcd
Fix UT
hvanhovell May 5, 2018
cbc164d
Appease scalastyle
hvanhovell May 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix compilation
  • Loading branch information
@hvanhovell
hvanhovell committed Apr 20, 2018
commit eb6dd8033c532f7bcf103ee6096b9dedd91176fd
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ package object expressions {
// Collect matching attributes given a name and a lookup.
def collectMatches(name: String, candidates: Option[Seq[Attribute]]): Seq[Attribute] = {
candidates.toSeq.flatMap(_.collect {
case a if !a.isGenerated && resolver(a.name, name) => a.withName(name)
case a if resolver(a.name, name) => a.withName(name)
})
}

Expand Down