Skip to content

[SPARK-2490] Change recursive visiting on RDD dependencies to iterative approach #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viirya wants to merge 4 commits into from
Closed

[SPARK-2490] Change recursive visiting on RDD dependencies to iterative approach #1418

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
900538b
change recursive visiting on rdd's dependencies to iterative approach…
viirya Jul 15, 2014
8742dbb
comply with code style.
viirya Jul 27, 2014
5f072a7
add comments to explain Stack usage.
viirya Jul 30, 2014
6b2c615
change function name; comply with code style.
viirya Jul 31, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
comply with code style.
  • Loading branch information
@viirya
viirya committed Jul 27, 2014
commit 8742dbb528153e760dbbbe426978e27e6f1742ce
15 changes: 10 additions & 5 deletions core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,8 +292,9 @@ class DAGScheduler(
}
}
waitingForVisit.push(rdd)
while (!waitingForVisit.isEmpty)
while (!waitingForVisit.isEmpty) {
visit(waitingForVisit.pop())
}
parents.toList
}

Expand All @@ -307,8 +308,9 @@ class DAGScheduler(
for (dep <- r.dependencies) {
dep match {
case shufDep: ShuffleDependency[_, _, _] =>
if (!shuffleToMapStage.contains(shufDep.shuffleId))
if (!shuffleToMapStage.contains(shufDep.shuffleId)) {
parents.push(shufDep)
}

waitingForVisit.push(shufDep.rdd)
case _ =>
Expand All @@ -319,8 +321,9 @@ class DAGScheduler(
}

waitingForVisit.push(rdd)
while (!waitingForVisit.isEmpty)
while (!waitingForVisit.isEmpty) {
visit(waitingForVisit.pop())
}
parents
}

Expand All @@ -347,8 +350,9 @@ class DAGScheduler(
}
}
waitingForVisit.push(stage.rdd)
while (!waitingForVisit.isEmpty)
while (!waitingForVisit.isEmpty) {
visit(waitingForVisit.pop())
}
missing.toList
}

Expand Down Expand Up @@ -1161,8 +1165,9 @@ class DAGScheduler(
}
}
waitingForVisit.push(stage.rdd)
while (!waitingForVisit.isEmpty)
while (!waitingForVisit.isEmpty) {
visit(waitingForVisit.pop())
}
visitedRdds.contains(target.rdd)
}

Expand Down