Skip to content

SPARK-897: preemptively serialize closures #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
willb wants to merge 8 commits into from
Closed

SPARK-897: preemptively serialize closures #143

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ed2ccf0
Test cases for SPARK-897.
willb Mar 13, 2014
5bfff24
Adds proactive closure-serializablilty checking
willb Mar 13, 2014
abe816b
Make proactive serializability checking optional.
willb Mar 14, 2014
be1ecd6
Don't check serializability of DStream transforms.
willb Mar 14, 2014
b215dea
Fixed spurious failures in ImplicitOrderingSuite
willb May 1, 2014
3b3f74a
Stylistic and doc cleanups.
willb Jun 29, 2014
64d04d2
FailureSuite now checks both messages and causes.
willb Jun 29, 2014
bceab8a
Commented DStream corner cases for serializability checking.
willb Jun 30, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make proactive serializability checking optional. 
SparkContext.clean uses ClosureCleaner's proactive serializability
checking by default.  This commit adds a parameter to the clean method
of SparkContext that allows clients to specify that serializability
checking should not occur as part of closure cleaning.
  • Loading branch information
@willb
willb committed Jun 18, 2014
commit abe816b726c8647caa5c8ebcc5047189eb2dd32d
4 changes: 2 additions & 2 deletions core/src/main/scala/org/apache/spark/SparkContext.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1205,8 +1205,8 @@ class SparkContext(config: SparkConf) extends Logging {
* Clean a closure to make it ready to serialized and send to tasks
* (removes unreferenced variables in $outer's, updates REPL variables)
*/
private[spark] def clean[F <: AnyRef](f: F): F = {
ClosureCleaner.clean(f)
private[spark] def clean[F <: AnyRef](f: F, checkSerializable: Boolean = true): F = {
Copy link
Contributor

@rxin rxin Jun 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you document checkSerializable in the doc? (like what exception does it throw)

ClosureCleaner.clean(f, checkSerializable)
f
}

Expand Down