Skip to content

[SPARK-16714][SQL] Refactor type widening for consistency #14389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
petermaxlee wants to merge 7 commits into from
Closed

[SPARK-16714][SQL] Refactor type widening for consistency #14389

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9774605
[SPARK-16714][SQL] map, struct function should accept decimals with d…
petermaxlee Jul 28, 2016
57bbe81
Make it more consistent.
petermaxlee Jul 29, 2016
afca003
Fix compile
petermaxlee Jul 29, 2016
929c39f
Remove unused methods.
petermaxlee Jul 29, 2016
071b01d
Rename test case
petermaxlee Jul 29, 2016
b9f94fe
Fix test
petermaxlee Jul 29, 2016
ffd1734
Code review
petermaxlee Jul 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix compile
  • Loading branch information
@petermaxlee
petermaxlee committed Jul 29, 2016
commit afca0032e5f1365fdd6face07cedec44bb000e25
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ object TypeCoercion {
* i.e. the main difference with [[findTightestCommonTypeOfTwo]] is that here we allow some
Copy link
Contributor

@cloud-fan cloud-fan Jul 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also mention the string promotion here?

Copy link
Contributor Author

@petermaxlee petermaxlee Jul 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

* loss of precision when widening decimal and double.
*/
private def findWiderTypeForTwo(t1: DataType, t2: DataType): Option[DataType] = (t1, t2) match {
def findWiderTypeForTwo(t1: DataType, t2: DataType): Option[DataType] = (t1, t2) match {
case (t1: DecimalType, t2: DecimalType) =>
Some(DecimalPrecision.widerDecimalType(t1, t2))
case (t: IntegralType, d: DecimalType) =>
Expand Down