Skip to content

[Spark-16791] [SQL] cast struct with timestamp field fails #14400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eyalfa wants to merge 6 commits into from
Closed

[Spark-16791] [SQL] cast struct with timestamp field fails #14400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
456de17
SPARK-16791_cast_struct_with_timestamp_field_fails: added a failing t…
Jul 29, 2016
f13113d
SPARK-16791_cast_struct_with_timestamp_field_fails: trivial fix.
Jul 29, 2016
a3b456c
SPARK-16791_cast_struct_with_timestamp_field_fails: fix style comment…
Jul 29, 2016
34fdb78
SPARK-16791_cast_struct_with_timestamp_field_fails: some more formatt…
Jul 30, 2016
6e7f69f
SPARK-16791_cast_struct_with_timestamp_field_fails: yet another forma…
Jul 30, 2016
e0549a9
SPARK-16791_cast_struct_with_timestamp_field_fails: remove one more e…
Aug 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ case class Cast(child: Expression, dataType: DataType) extends UnaryExpression w
}

private[this] def cast(from: DataType, to: DataType): Any => Any = to match {
case dt if dt == child.dataType => identity[Any]
case dt if dt == from => identity[Any]
case StringType => castToString(from)
case BinaryType => castToBinary(from)
case DateType => castToDate(from)
Expand Down
10 changes: 10 additions & 0 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,6 +727,16 @@ class CastSuite extends SparkFunSuite with ExpressionEvalHelper {
}
}

test("cast struct with a timestamp field") {
val originalSchema = new StructType().add("tsField", TimestampType, nullable = false)
// nine out of ten times I'm casting a struct, it's to normalize its fields nullability
val targetSchema = new StructType().add("tsField", TimestampType, nullable = true)

val inp = Literal.create(InternalRow(0L), originalSchema)
val expected = InternalRow(0L)
checkEvaluation(cast(inp, targetSchema), expected)
}

test("complex casting") {
val complex = Literal.create(
Row(
Expand Down