Skip to content

Update JavaSparkContextVarargsWorkaround.java #14402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SakalyaDeshpande wants to merge 11 commits into from
Closed

Update JavaSparkContextVarargsWorkaround.java #14402

Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2ec652c
Update JavaSparkContextVarargsWorkaround.java
Jul 29, 2016
21a8e5a
Merge pull request #1 from sakky11/sakky11-patch-1
Jul 29, 2016
94927c3
Update JavaSparkContextVarargsWorkaround.java
Jul 29, 2016
3ecf5af
Merge pull request #2 from sakky11/sakky11-patch-2
Jul 29, 2016
ca46d92
Merge pull request #3 from apache/master
Jul 29, 2016
fe18e3c
Merge pull request #5 from apache/master
Jul 30, 2016
9cfa0e3
Update JavaSparkContextVarargsWorkaround.java
Jul 30, 2016
3e831e5
Merge pull request #6 from sakky11/sakky11-patch-4
Jul 30, 2016
3336629
Merge pull request #9 from apache/master
Jul 30, 2016
f4258a2
Update JavaSparkContextVarargsWorkaround.java
Jul 30, 2016
f51cf1b
Merge pull request #10 from sakky11/sakky11-patch-7
Jul 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions core/src/main/java/org/apache/spark/api/java/JavaSparkContextVarargsWorkaround.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,11 @@ public final <K, V> JavaPairRDD<K, V> union(JavaPairRDD<K, V>... rdds) {
if (rdds.length == 0) {
throw new IllegalArgumentException("Union called on empty list");
}
List<JavaPairRDD<K, V>> rest = new ArrayList<>(rdds.length - 1);
for (int i = 1; i < rdds.length; i++) {
rest.add(rdds[i]);
}
rest = populateRDDList(rdds);
return union(rdds[0], rest);
}

public final List<T> populateRDDList(T rdds) {
public static final List<T> populateRDDList(T rdds) {
Copy link
Member

@srowen srowen Jul 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing -- private? And doesn't this have to be T... rdds to work?

Copy link
Author

@SakalyaDeshpande SakalyaDeshpande Jul 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with making the method "private".But rdds is not any varargs so why do we need ...??

Copy link
Member

@srowen srowen Jul 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't build. You're using T like an array type but it isn't. It has to be an array type as far as the method is concerned. T[] would be fine as the type.

Copy link
Author

@SakalyaDeshpande SakalyaDeshpande Jul 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a build with T...

Copy link
Author

@SakalyaDeshpande SakalyaDeshpande Jul 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this work ??

List<T> rest = new ArrayList<>(rdds.length - 1);
for (int i = 1; i < rdds.length; i++) {
rest.add(rdds[i]);
Expand Down