[SPARK-16778][SQL][TRIVIAL] Fix deprecation warning with SQLContext #14406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // We create a new context here to avoid order dependence with other tests that might call | ||
| // clear(). | ||
| val newContext = new SQLContext(sparkContext) | ||
| val newContext = new SQLContext(SparkSession.builder().sparkContext(sc).getOrCreate()) |
Member
There was a problem hiding this comment.
sc has to be sparkContext here, no? we're about to find out from Jenkins
Contributor
Author
There was a problem hiding this comment.
oops thought this built locally but I guess I was on the wrong branch.
Member
|
Jenkins test this please |
|
Test build #63017 has finished for PR 14406 at commit
|
|
Test build #63049 has finished for PR 14406 at commit
|
Member
|
OK that looks reasonable |
Member
|
Merged to master/2.0 |
asfgit
pushed a commit
that referenced
this pull request
Aug 1, 2016
## What changes were proposed in this pull request? Change to non-deprecated constructor for SQLContext. ## How was this patch tested? Existing tests Author: Holden Karau <[email protected]> Closes #14406 from holdenk/SPARK-16778-fix-use-of-deprecated-SQLContext-constructor. (cherry picked from commit 1e9b59b) Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change to non-deprecated constructor for SQLContext.
How was this patch tested?
Existing tests