Skip to content

[SPARK-16796] [Web UI] Visible passwords on Spark environment page #14409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Devian-ua wants to merge 4 commits into from
Closed

[SPARK-16796] [Web UI] Visible passwords on Spark environment page #14409

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f17ce1
[SPARK-16796] [Web UI] Visible passwords on Spark environment page
Devian-ua Jul 29, 2016
e97f894
Change Seq to Set for passwordProperties
Devian-ua Jul 29, 2016
1bee0da
[SPARK-16796][Web UI] Visible passwords on Spark environment page
Devian-ua Jul 31, 2016
e4b617c
Refactor removePass to follow scala style
Devian-ua Aug 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,20 @@ import org.apache.spark.ui.{UIUtils, WebUIPage}

private[ui] class EnvironmentPage(parent: EnvironmentTab) extends WebUIPage("") {
private val listener = parent.listener

val passwordProperties: Set[String] = Set("spark.ssl.keyPassword",
"spark.ssl.keyStorePassword", "spark.ssl.trustStorePassword")

def removePass(kv: (String, String)): (String, String) = {
Copy link
Member

@srowen srowen Jul 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private? agree with filtering anything whose key has "password" (not case sensitive). Check for other instances where listener.sparkProperties is accessed too?

if (passwordProperties.contains(kv._1)) {
return (kv._1, "******")
}
kv
}
def render(request: HttpServletRequest): Seq[Node] = {
val runtimeInformationTable = UIUtils.listingTable(
propertyHeader, jvmRow, listener.jvmInformation, fixedWidth = true)
val sparkPropertiesTable = UIUtils.listingTable(
propertyHeader, propertyRow, listener.sparkProperties, fixedWidth = true)
propertyHeader, propertyRow, listener.sparkProperties.map(removePass), fixedWidth = true)
Copy link
Member

@srowen srowen Jul 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be just taste, but isn't this easier inline?

val redactedProperties = listener.sparkProperties.map { case (key, value) => 
  (key, if (key.toLowerCase.contains("password")) "******" else value)
}

Are there any other instances where properties are displayed that need redacting?

val systemPropertiesTable = UIUtils.listingTable(
propertyHeader, propertyRow, listener.systemProperties, fixedWidth = true)
val classpathEntriesTable = UIUtils.listingTable(
Expand Down