[SPARK-16770][BUILD] Fix JLine dependency management and version (Sca…

[stsc-pentasys]

What changes were proposed in this pull request?

As of Scala 2.11.x there is no longer a org.scala-lang:jline version aligned to the scala version itself. Scala console now uses the plain jline:jline module. Spark's dependency management did not reflect this change properly, causing Maven to pull in Jline via transitive dependency. Unfortunately Jline 2.12 contained a minor but very annoying bug rendering the shell almost useless for developers with german keyboard layout. This request contains the following chages:

• Exclude transitive dependency 'jline:jline' from hive-exec module
• Remove global properties 'jline.version' and 'jline.groupId'
• Add both properties and dependency to 'scala-2.11' profile
• Add explicit dependency on 'jline:jline' to module 'spark-repl'

How was this patch tested?

• Running mvn dependency:tree and checking for correct Jline version 2.12.1
• Running full builds with assembly and checking for jline-2.12.1.jar in 'lib' folder of generated tarball

[srowen]

You've added a new dependencyManagement section which won't work. Add to the existing one.

[stsc-pentasys]

I just aligned it with the profile for scala 2.10.x, And from my point of view it works. Includes the right Jline version in the delivered tarball.

[srowen]

This will fail to build because the deps/* files haven't been updated. The dev/test-dependencies.sh script can do this.

[srowen]

OK @stsc-pentasys I think I'm on board with this after I reminded myself of how it works. One last suggestion. It seems like this should be in dependencyManagment outside of any profile:

          <dependency>
            <groupId>${jline.groupid}</groupId>
            <artifactId>jline</artifactId>
            <version>${jline.version}</version>
          </dependency>

That much is constant. It's the version and group that vary with Scala, and the profiles already set those.

[stsc-pentasys]

That's of course the cleanest solution.

[srowen]

Yep that LGTM

[srowen]

Jenkins test this please

[SparkQA]

Test build #63184 has finished for PR 14429 at commit 35cc6c3.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #63185 has finished for PR 14429 at commit 35cc6c3.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

Merged to master/2.0