[SPARK-16836][SQL] Add support for CURRENT_DATE/CURRENT_TIMESTAMP literals #14442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #63088 has finished for PR 14442 at commit
|
Contributor
|
LGTM |
Member
|
LGTM FYI, MySQL and PostgreSQL support NOW as a synonym of CURRENT_TIMESTAMP |
Contributor
|
Can you add an end-to-end test for this in SQLQuerySuite? It's not a great place but we will refactor it soon. |
|
Test build #63117 has finished for PR 14442 at commit
|
Contributor
|
Thanks - merging in master/2.0. |
asfgit
pushed a commit
that referenced
this pull request
Aug 2, 2016
…erals ## What changes were proposed in this pull request? In Spark 1.6 (with Hive support) we could use `CURRENT_DATE` and `CURRENT_TIMESTAMP` functions as literals (without adding braces), for example: ```SQL select /* Spark 1.6: */ current_date, /* Spark 1.6 & Spark 2.0: */ current_date() ``` This was accidentally dropped in Spark 2.0. This PR reinstates this functionality. ## How was this patch tested? Added a case to ExpressionParserSuite. Author: Herman van Hovell <[email protected]> Closes #14442 from hvanhovell/SPARK-16836. (cherry picked from commit 2330f3e) Signed-off-by: Reynold Xin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In Spark 1.6 (with Hive support) we could use
CURRENT_DATEandCURRENT_TIMESTAMPfunctions as literals (without adding braces), for example:This was accidentally dropped in Spark 2.0. This PR reinstates this functionality.
How was this patch tested?
Added a case to ExpressionParserSuite.