Skip to content

[SPARK-16875][SQL] Add args checking for DataSet randomSplit and sample #14478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhengruifeng wants to merge 3 commits into from
Closed

[SPARK-16875][SQL] Add args checking for DataSet randomSplit and sample #14478

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6e9281
create pr
zhengruifeng Aug 3, 2016
3ea8518
update bound
zhengruifeng Aug 3, 2016
4b0efea
add checking for RDD
zhengruifeng Aug 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update bound
  • Loading branch information
@zhengruifeng
zhengruifeng committed Aug 3, 2016
commit 3ea85189f2ad4abaa45282476de980ad7886b297
2 changes: 1 addition & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1576,7 +1576,7 @@ class Dataset[T] private[sql](
* @since 2.0.0
*/
def randomSplit(weights: Array[Double], seed: Long): Array[Dataset[T]] = {
require(weights.forall(_ > 0),
require(weights.forall(_ >= 0),
s"Weights must be nonnegative, but got ${weights.mkString("[", ",", "]")}")
require(weights.sum > 0,
s"Sum of weights must be positive, but got ${weights.mkString("[", ",", "]")}")
Expand Down