Skip to content

[SPARK-16796][Web UI] Mask spark.authenticate.secret on Spark environ… #14484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Devian-ua wants to merge 2 commits into from
Closed

[SPARK-16796][Web UI] Mask spark.authenticate.secret on Spark environ… #14484

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ba65a3
[SPARK-16796][Web UI] Mask spark.authenticate.secret on Spark environ…
Devian-ua Aug 3, 2016
a73d818
Filter every property containing secret
Devian-ua Aug 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Filter every property containing secret
  • Loading branch information
@Devian-ua
Devian-ua committed Aug 3, 2016
commit a73d81834a62546048fe0c4ddd3158b6a2edffc4
4 changes: 1 addition & 3 deletions core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,9 @@ import org.apache.spark.ui.{UIUtils, WebUIPage}

private[ui] class EnvironmentPage(parent: EnvironmentTab) extends WebUIPage("") {
private val listener = parent.listener
// Spark Properties (lowercase). Their values will be changed to ***** in WebUI
private val propertiesToMask = Set("spark.authenticate.secret")

private def removePass(kv: (String, String)): (String, String) = {
if (kv._1.toLowerCase.contains("password") || propertiesToMask.contains(kv._1.toLowerCase)) {
if (kv._1.toLowerCase.contains("password") || kv._1.toLowerCase.contains("secret")) {
(kv._1, "******")
} else kv
}
Expand Down