Skip to content

[SPARK-16409] [SQL] regexp_extract with optional groups causes NPE #14504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srowen wants to merge 4 commits into from
Closed

[SPARK-16409] [SQL] regexp_extract with optional groups causes NPE #14504

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6259c06
Handle case that regex matches, but group does not, in regexp_extract
srowen Aug 5, 2016
75d62ae
Add test for non-matching optional group in regexp_extract
srowen Aug 5, 2016
545c8de
Add Python test for good measure
srowen Aug 6, 2016
b835bd3
Actually fix in generated code too
srowen Aug 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test for non-matching optional group in regexp_extract
  • Loading branch information
@srowen
srowen committed Aug 5, 2016
commit 75d62ae1ce5c33a8c4929aa3500aba1ebb916a09
8 changes: 8 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,14 @@ class StringFunctionsSuite extends QueryTest with SharedSQLContext {
Row("300", "100") :: Row("400", "100") :: Row("400-400", "100") :: Nil)
}

test("non-matching optional group") {
val df = Seq("aaaac").toDF("s")
checkAnswer(
df.select(regexp_extract($"s", "(a+)(b)?(c)", 2)),
Row("")
)
}

test("string ascii function") {
val df = Seq(("abc", "")).toDF("a", "b")
checkAnswer(
Expand Down