Skip to content

[SPARK-16947][SQL] Support type coercion and foldable expression for inline tables #14676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
petermaxlee wants to merge 15 commits into from
Closed

[SPARK-16947][SQL] Support type coercion and foldable expression for inline tables #14676

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d7acae5
[SPARK-16947][SQL] Support type coercion and foldable expression for …
petermaxlee Aug 17, 2016
6a0450b
Add one more negative test case for aggregate expression.
petermaxlee Aug 17, 2016
2327b79
update doc about visibility for testing.
petermaxlee Aug 17, 2016
fcc3caf
Fix PlanParserSuite
petermaxlee Aug 17, 2016
f597bae
Merge branch 'master' into SPARK-16947
petermaxlee Aug 17, 2016
092605b
Fix tests
petermaxlee Aug 17, 2016
4723902
Add two cases with null.
petermaxlee Aug 17, 2016
c1071af
Code review
petermaxlee Aug 17, 2016
1b39a97
Code review
petermaxlee Aug 18, 2016
2e68438
small code review
petermaxlee Aug 18, 2016
fb9de34
Add comment explaining attribute reference.
petermaxlee Aug 18, 2016
aed7c5e
nullability and remove rand
petermaxlee Aug 18, 2016
08f4e39
Merge remote-tracking branch 'apache/master' into SPARK-16947
petermaxlee Aug 18, 2016
285b941
updated test case comment
petermaxlee Aug 18, 2016
88e7272
Fix merge bug
petermaxlee Aug 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix merge bug
  • Loading branch information
@petermaxlee
petermaxlee committed Aug 18, 2016
commit 88e727260f80819c58bb3cef3ba79d9bf86990fe
1 change: 1 addition & 0 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ case class UnresolvedInlineTable(
extends LeafNode {

lazy val expressionsResolved: Boolean = rows.forall(_.forall(_.resolved))
Copy link
Contributor

@hvanhovell hvanhovell Aug 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used only once. Lets move this code into that location.

Copy link
Contributor Author

@petermaxlee petermaxlee Aug 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do want this memoized, so a lazy val is better here.

override lazy val resolved = false
override def output: Seq[Attribute] = Nil
}

Expand Down