Skip to content

[SPARK-17158][SQL] Change error message for out of range numeric literals #14721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srinathshankar wants to merge 3 commits into from
Closed

[SPARK-17158][SQL] Change error message for out of range numeric literals #14721

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da07ad9
[SC-4296][SQL] Change error message for out of range numeric literals
srinathshankar Aug 17, 2016
89a73e3
Fixed organization of parameters into lists
srinathshankar Aug 19, 2016
19582ff
Fixed tests and added expression parser test for double
srinathshankar Aug 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixed tests and added expression parser test for double
  • Loading branch information
@srinathshankar
srinathshankar committed Aug 20, 2016
commit 19582ff633932c3ec0a6804bec9314a3390a6404
8 changes: 5 additions & 3 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,19 +375,21 @@ class ExpressionParserSuite extends PlanTest {

// Tiny Int Literal
assertEqual("10Y", Literal(10.toByte))
intercept("-1000Y", s"does not fit in range [-${Byte.MinValue}, ${Byte.MaxValue}]")
intercept("-1000Y", s"does not fit in range [${Byte.MinValue}, ${Byte.MaxValue}]")

// Small Int Literal
assertEqual("10S", Literal(10.toShort))
intercept("40000S", s"does not fit in range [-${Short.MinValue}, ${Short.MaxValue}]")
intercept("40000S", s"does not fit in range [${Short.MinValue}, ${Short.MaxValue}]")

// Long Int Literal
assertEqual("10L", Literal(10L))
intercept("78732472347982492793712334L",
s"does not fit in range [-${Long.MinValue}, ${Long.MaxValue}]")
s"does not fit in range [${Long.MinValue}, ${Long.MaxValue}]")

// Double Literal
assertEqual("10.0D", Literal(10.0D))
intercept("-1.8E308D", s"does not fit in range")
intercept("1.8E308D", s"does not fit in range")
// TODO we need to figure out if we should throw an exception here!
assertEqual("1E309", Literal(Double.PositiveInfinity))
}
Expand Down