Skip to content

[SPARK-17187][SQL] Supports using arbitrary Java object as internal aggregation buffer object #14753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
clockfly wants to merge 12 commits into from
Closed

[SPARK-17187][SQL] Supports using arbitrary Java object as internal aggregation buffer object #14753

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
10861b2
object aggregation buffer
clockfly Aug 19, 2016
0fdc1ea
fix comments
clockfly Aug 23, 2016
d3108ab
fix review comments
clockfly Aug 23, 2016
2873765
fix review comments
clockfly Aug 23, 2016
7190eb0
fix review comments
clockfly Aug 24, 2016
5904bcd
on viirya's comment
clockfly Aug 24, 2016
8c8bd9a
on yin's comment
clockfly Aug 24, 2016
7e7cb85
On wenchen's comment
clockfly Aug 24, 2016
86166a1
On wenchen's comment
clockfly Aug 24, 2016
e060d21
On wenchen's comment
clockfly Aug 24, 2016
ac8e36a
add test for nullable aggregation function
clockfly Aug 25, 2016
ca574e1
use while loop
yhuai Aug 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
On wenchen's comment
  • Loading branch information
@clockfly
clockfly committed Aug 24, 2016
commit 86166a12a1cc411f93bb96a5cf3c284a1ffb651c
3 changes: 2 additions & 1 deletion ...alyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,8 @@ abstract class TypedImperativeAggregate[T] extends ImperativeAggregate {

/**
* In-place replaces the aggregation buffer object stored at buffer's index
* `mutableAggBufferOffset`, with SparkSQL internally supported underlying storage format.
* `mutableAggBufferOffset`, with SparkSQL internally supported underlying storage format
* (BinaryType).
*/
final def serializeAggregateBufferInPlace(buffer: MutableRow): Unit = {
val bufferObject = getField[T](buffer, mutableAggBufferOffset)
Expand Down