Skip to content

[SPARK-17256][Deploy, Windows]Check before adding double quotes in spark/bin batch files to avoid cutting off arguments that double quoted as contain special character such as mysql connection string. #14807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
qualiu wants to merge 2 commits into from
Closed

[SPARK-17256][Deploy, Windows]Check before adding double quotes in spark/bin batch files to avoid cutting off arguments that double quoted as contain special character such as mysql connection string. #14807

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6b1c60
Remove double quotes in spark/bin batch files to avoid cutting off ar…
lqm678 Aug 25, 2016
7059639
More conservative : Check before adding quotes in spark/bin/spark-sub…
lqm678 Aug 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
More conservative : Check before adding quotes in spark/bin/spark-sub… 
…mit.cmd files. In fact the same effect as last commit because currently it doesn't work if full path to spark-submit.cmd has space.
  • Loading branch information
@lqm678
lqm678 committed Aug 26, 2016
commit 7059639a21138f494e83da5bbfe800dfca7789d8
7 changes: 6 additions & 1 deletion bin/spark-class.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,9 @@ rem
rem This is the entry point for running a Spark class. To avoid polluting
rem the environment, it just launches a new cmd to do the real work.

cmd /V /E /C %~dp0spark-class2.cmd %*
echo "%~dp0spark-class2.cmd"|findstr /C:" "
if %ERRORLEVEL% EQU 0 (
cmd /V /E /C "%~dp0spark-class2.cmd" %*
) else (
cmd /V /E /C %~dp0spark-class2.cmd %*
)
7 changes: 6 additions & 1 deletion bin/spark-shell.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,9 @@ rem
rem This is the entry point for running Spark shell. To avoid polluting the
rem environment, it just launches a new cmd to do the real work.

cmd /V /E /C %~dp0spark-shell2.cmd %*
echo "%~dp0spark-shell2.cmd"|findstr /C:" "
if %ERRORLEVEL% EQU 0 (
cmd /V /E /C "%~dp0spark-shell2.cmd" %*
) else (
cmd /V /E /C %~dp0spark-shell2.cmd %*
)
7 changes: 6 additions & 1 deletion bin/spark-submit.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,9 @@ rem
rem This is the entry point for running Spark submit. To avoid polluting the
rem environment, it just launches a new cmd to do the real work.

cmd /V /E /C %~dp0spark-submit2.cmd %*
echo "%~dp0spark-submit2.cmd"|findstr /C:" "
if %ERRORLEVEL% EQU 0 (
cmd /V /E /C "%~dp0spark-submit2.cmd" %*
) else (
cmd /V /E /C %~dp0spark-submit2.cmd %*
)