Skip to content

[SPARK-17577][SparkR][Core] SparkR support add files to Spark job and get by executors #15131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yanboliang wants to merge 6 commits into from
Closed

[SPARK-17577][SparkR][Core] SparkR support add files to Spark job and get by executors #15131

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5c49428
SparkR support add files to Spark job and get by executors.
yanboliang Sep 17, 2016
65be499
Fix docs.
yanboliang Sep 18, 2016
542b981
Make SparkContext.addFile work well on Windows.
yanboliang Sep 18, 2016
fa82b3a
Refactor spark.addFile, spark.getSparkFiles API.
yanboliang Sep 18, 2016
acfbd8a
Change path to uri.toString.
yanboliang Sep 18, 2016
9ed3c68
Add export.
yanboliang Sep 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change path to uri.toString.
  • Loading branch information
@yanboliang
yanboliang committed Sep 18, 2016
commit acfbd8a8837449932bccbb5378ddb909188bfad8
4 changes: 2 additions & 2 deletions core/src/main/scala/org/apache/spark/SparkContext.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1457,8 +1457,8 @@ class SparkContext(config: SparkConf) extends Logging with ExecutorAllocationCli
logInfo(s"Added file $path at $key with timestamp $timestamp")
// Fetch the file locally so that closures which are run on the driver can still use the
// SparkFiles API to access files.
Utils.fetchFile(path, new File(SparkFiles.getRootDirectory()), conf, env.securityManager,
hadoopConfiguration, timestamp, useCache = false)
Utils.fetchFile(uri.toString, new File(SparkFiles.getRootDirectory()), conf,
Copy link
Member

@felixcheung felixcheung Sep 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be some tests we can add for this change?

Copy link
Member

@HyukjinKwon HyukjinKwon Sep 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my peraonal opinion, I thought it's okay (I thought about this for a while) because Utils.fetchFile wants the first argument as url not path. So, this might be a valid correction without tests because we fixed the argument to what the function initially wants. But no strong opinion.

env.securityManager, hadoopConfiguration, timestamp, useCache = false)
postEnvironmentUpdate()
}
}
Expand Down