Skip to content

[SPARK-17854][SQL] rand/randn allows null/long as input seed #15432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 12 commits into from
+135 −22
Closed

[SPARK-17854][SQL] rand/randn allows null/long as input seed #15432

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5213bd6
rand/randn allows null as input seed
HyukjinKwon Oct 11, 2016
182548b
Use ExpectsInputTypes and allow LongType and IntegerType
HyukjinKwon Oct 12, 2016
2453460
Override constructor
HyukjinKwon Oct 12, 2016
fec5f42
Add test cases for constant folding and improve documentation
HyukjinKwon Oct 16, 2016
7bc0a19
Add some more cases for exceptions
HyukjinKwon Oct 16, 2016
9c56094
Improve documentation
HyukjinKwon Oct 17, 2016
30179d8
Improve exception message and documentation
HyukjinKwon Oct 17, 2016
3283d3a
Fix the test too
HyukjinKwon Oct 17, 2016
a523302
Add examples for null as an argument
HyukjinKwon Nov 4, 2016
b432355
Fix the tests accordingly
HyukjinKwon Nov 4, 2016
160ea54
Move the tests into sql query test suit
HyukjinKwon Nov 4, 2016
9b9a49f
Specify the date type for literals
HyukjinKwon Nov 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add some more cases for exceptions
  • Loading branch information
@HyukjinKwon
HyukjinKwon committed Nov 4, 2016
commit 7bc0a192c3887cbd8806dae9eeb5f73fe731b80a
10 changes: 10 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1741,5 +1741,15 @@ class DataFrameSuite extends QueryTest with SharedSQLContext {
testData.selectExpr("randn(cast(NULL AS LONG))"), testData.selectExpr("randn(0L)"))
checkAnswer(
testData.selectExpr("randn(cast(3L / 12L AS LONG))"), testData.selectExpr("randn(0L)"))

val eOne = intercept[AnalysisException] {
testData.selectExpr("rand(key)").collect()
}
assert(eOne.message.contains("Input argument to rand must be an integer/long literal."))

val eTwo = intercept[AnalysisException] {
testData.selectExpr("randn(key)").collect()
}
assert(eTwo.message.contains("Input argument to randn must be an integer/long literal."))
}
}