Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
5f70b1d
Add examples (extend) in each function and improve documentation with…
HyukjinKwon Oct 17, 2016
77abafa
aggregate OK
HyukjinKwon Oct 18, 2016
8cd6d80
xml OK
HyukjinKwon Oct 18, 2016
2614572
arithmetic OK
HyukjinKwon Oct 18, 2016
29d0262
bitwiseExpressions OK and double-check others
HyukjinKwon Oct 18, 2016
710c68e
CallMethodViaReflection OK
HyukjinKwon Oct 18, 2016
1d44ec3
Cast OK
HyukjinKwon Oct 18, 2016
78b1fc7
collectionOperations OK
HyukjinKwon Oct 18, 2016
e2062af
complexTypeCreator OK and double check others
HyukjinKwon Oct 19, 2016
e9672db
conditionalExpressions OK
HyukjinKwon Oct 19, 2016
9baa847
datetimeExpressions OK
HyukjinKwon Oct 19, 2016
fff85f6
generators OK
HyukjinKwon Oct 19, 2016
2462775
InputFileName OK
HyukjinKwon Oct 19, 2016
10892fb
jsonExpressions OK
HyukjinKwon Oct 19, 2016
45e7f99
mathExpressions OK, double check others and fix scala style
HyukjinKwon Oct 19, 2016
1d69e40
misc OK, double-check others and ignore a test in SQLQuerySuite for now
HyukjinKwon Oct 20, 2016
9b24e78
MonotonicallyIncreasingID OK
HyukjinKwon Oct 20, 2016
ed1c839
nullExpressions OK
HyukjinKwon Oct 20, 2016
1535186
predicates OK
HyukjinKwon Oct 20, 2016
8efee7e
randomExpressions OK
HyukjinKwon Oct 20, 2016
a111d2a
regexpExpressions OK
HyukjinKwon Oct 20, 2016
a8ddcc2
SparkPartitionID OK
HyukjinKwon Oct 20, 2016
99b5658
tringExpressions OK
HyukjinKwon Oct 20, 2016
a29472e
windowExpressions OK
HyukjinKwon Oct 20, 2016
73ccda0
conditionalExpressions OK, double-check others and fix tests
HyukjinKwon Oct 20, 2016
d927bff
double-check
HyukjinKwon Oct 20, 2016
91d2ab5
Fix tests in SQLQuerySuite and DDLSuite first
HyukjinKwon Oct 21, 2016
7841860
Take out a space after `Extended Usage:`.
HyukjinKwon Oct 21, 2016
01eecfe
Consistent spacing in Examples
HyukjinKwon Oct 21, 2016
1979d92
Remove repeated _FUNC_, consolidate usages and simplify the arguments
HyukjinKwon Oct 21, 2016
d56ac66
Fix tests DDLSuite, SQLQuerySuite and hive/SQLQuerySuite with consist…
HyukjinKwon Oct 21, 2016
8a773d4
Fix scala style.
HyukjinKwon Oct 21, 2016
f71e39e
double-check
HyukjinKwon Oct 21, 2016
caa71c8
double-check again
HyukjinKwon Oct 22, 2016
5163a87
Address Sean's comments
HyukjinKwon Oct 22, 2016
f8d11aa
another double-check
HyukjinKwon Oct 22, 2016
da40f85
Fix the tests in DDLSuite
HyukjinKwon Oct 22, 2016
feafdc2
another double-check
HyukjinKwon Oct 23, 2016
2656c62
another double-check
HyukjinKwon Oct 23, 2016
15c02ca
Address comments and another double-check
HyukjinKwon Oct 24, 2016
035baef
revert mistakes
HyukjinKwon Oct 24, 2016
c55ecb6
another double-check and remove extra change for newlines
HyukjinKwon Oct 25, 2016
ad7b71d
Address comments
HyukjinKwon Oct 26, 2016
3965d00
Address comments
HyukjinKwon Oct 27, 2016
498d69c
Missed ones
HyukjinKwon Oct 27, 2016
400cee5
add back-quotes, fix typos and specify the types more specifically
HyukjinKwon Oct 27, 2016
2b437fe
address type and more details
HyukjinKwon Oct 29, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
another double-check
  • Loading branch information
HyukjinKwon committed Oct 23, 2016
commit feafdc21317b4d05921b73f6231d8b0d498bad43
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ import org.apache.spark.util.Utils
Arguments:
class - a string literal that represents a fully-qualified class name.
method - a string literal that represents a method name.
arg - a string literal that represents arguments for the method.
arg - an expression of any type that represents arguments for the method.

Examples:
> SELECT _FUNC_('java.util.UUID', 'randomUUID');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ import org.apache.spark.sql.types._
usage = "expr1 _FUNC_ expr2 - Bitwise AND.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returns the result of bitwise AND of expr1 and expr2.

extended = """
Arguments:
expr1 - a integral numeric expression.
expr2 - a integral numeric expression.
expr1 - an integral numeric expression.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is integral numeric? Does it include byte?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it seems so.

spark-sql> SELECT cast(1 as byte) & cast(1 as byte) ;
1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you meant what is that. I referred IntegralType class. maybe I should fix that just to intergral expression.

expr2 - an integral numeric expression.

Examples:
> SELECT 3 _FUNC_ 5;
Expand Down Expand Up @@ -66,8 +66,8 @@ case class BitwiseAnd(left: Expression, right: Expression) extends BinaryArithme
usage = "expr1 _FUNC_ expr2 - Bitwise OR.",
extended = """
Arguments:
expr1 - a integral numeric expression.
expr2 - a integral numeric expression.
expr1 - an integral numeric expression.
expr2 - an integral numeric expression.

Examples:
> SELECT 3 _FUNC_ 5;
Expand Down Expand Up @@ -102,8 +102,8 @@ case class BitwiseOr(left: Expression, right: Expression) extends BinaryArithmet
usage = "expr1 _FUNC_ expr2 - Bitwise exclusive OR.",
extended = """
Arguments:
expr1 - a integral numeric expression.
expr2 - a integral numeric expression.
expr1 - an integral numeric expression.
expr2 - an integral numeric expression.

Examples:
> SELECT 3 _FUNC_ 5;
Expand Down Expand Up @@ -136,7 +136,7 @@ case class BitwiseXor(left: Expression, right: Expression) extends BinaryArithme
usage = "_FUNC_ expr - Bitwise NOT.",
extended = """
Arguments:
expr - a integral numeric expression.
expr - an integral numeric expression.

Examples:
> SELECT _FUNC_ 0;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -889,8 +889,8 @@ case class Pow(left: Expression, right: Expression)
usage = "_FUNC_(base, expr) - Bitwise left shift.",
extended = """
Arguments:
base - a integral numeric expression that defines the base number to shift.
expr - a integral numeric expression.
base - an integral numeric expression that defines the base number to shift.
expr - an integral numeric expression.

Examples:
> SELECT _FUNC_(2, 1);
Expand Down Expand Up @@ -927,8 +927,8 @@ case class ShiftLeft(left: Expression, right: Expression)
usage = "_FUNC_(base, expr) - Bitwise (signed) right shift.",
extended = """
Arguments:
base - a integral numeric expression that defines the base number to shift.
expr - a integral numeric expression.
base - an integral numeric expression that defines the base number to shift.
expr - an integral numeric expression.

Examples:
> SELECT _FUNC_(4, 1);
Expand Down Expand Up @@ -965,8 +965,8 @@ case class ShiftRight(left: Expression, right: Expression)
usage = "_FUNC_(base, expr) - Bitwise unsigned right shift.",
extended = """
Arguments:
base - a integral numeric expression that defines the base number to shift.
expr - a integral numeric expression.
base - an integral numeric expression that defines the base number to shift.
expr - an integral numeric expression.

Examples:
> SELECT _FUNC_(4, 1);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1499,8 +1499,8 @@ class DDLSuite extends QueryTest with SharedSQLContext with BeforeAndAfterEach {
Row(
"""Extended Usage:
| Arguments:
| expr1 - a integral numeric expression.
| expr2 - a integral numeric expression.
| expr1 - an integral numeric expression.
| expr2 - an integral numeric expression.
|
| Examples:
| > SELECT 3 ^ 5;
Expand Down