Skip to content

[SPARK-17993][SQL] Fix Parquet log output redirection #15538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mallman wants to merge 7 commits into from
Closed

[SPARK-17993][SQL] Fix Parquet log output redirection #15538

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c4b8251
[SPARK-17993][SQL] Perform Parquet log output redirection when
Oct 18, 2016
ad4ce9e
Improve code documentation to clarify the reasoning behind this strategy
Oct 20, 2016
42c44b0
Set parquet library logging threshold to ERROR for testing
Oct 26, 2016
07ba0be
Set def ensureParquetLogRedirection(): Unit =
Oct 27, 2016
696ebc0
Call ParquetFileFormat.ensureParquetLogRedirection when deserializing
Oct 30, 2016
b6f7e20
Call ParquetFileFormat.ensureParquetLogRedirection when deserializing
Oct 30, 2016
247ef91
Move Parquet log redirection code to a serializable Java class
Nov 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Call ParquetFileFormat.ensureParquetLogRedirection when deserializing 
ParquetFileFormat
  • Loading branch information
Michael Allman committed Nov 9, 2016
commit 696ebc0eb2f763c9245dc98903a62158d1b4d9d8
9 changes: 9 additions & 0 deletions ...src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

package org.apache.spark.sql.execution.datasources.parquet

import java.io.ObjectInputStream
import java.net.URI
import java.util.logging.{Logger => JLogger}

Expand Down Expand Up @@ -64,6 +65,14 @@ class ParquetFileFormat
// call.
ParquetFileFormat.ensureParquetLogRedirection

// Java serialization will not call the default constructor. Make sure we call
// ParquetFileFormat.ensureParquetLogRedirection in deserialization by implementing this hook
// method.
private def readObject(in: ObjectInputStream): Unit = {
in.defaultReadObject
ParquetFileFormat.ensureParquetLogRedirection
Copy link
Contributor

@ericl ericl Oct 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also call ensureParquetLogRedirection from some main class right? e.g. class Executor.

Copy link
Contributor Author

@mallman mallman Nov 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to keep this code isolated to the parquet implementation.

}

override def shortName(): String = "parquet"

override def toString: String = "ParquetFormat"
Expand Down