Skip to content

[SPARK-18030][Tests]Fix flaky FileStreamSourceSuite by not deleting the files #15699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zsxwing wants to merge 1 commit into from
Closed

[SPARK-18030][Tests]Fix flaky FileStreamSourceSuite by not deleting the files #15699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,6 @@ class FileStreamSourceTest extends StreamTest with SharedSQLContext with Private
}
}

case class DeleteFile(file: File) extends ExternalAction {
def runAction(): Unit = {
Utils.deleteRecursively(file)
}
}

/** Use `format` and `path` to create FileStreamSource via DataFrameReader */
def createFileStream(
format: String,
Expand Down Expand Up @@ -697,10 +691,6 @@ class FileStreamSourceSuite extends FileStreamSourceTest {
AddTextFileData("{'value': 'keep5'}", partitionBarSubDir, tmp),
CheckAnswer(("keep2", "foo"), ("keep3", "foo"), ("keep4", "bar"), ("keep5", "bar")),

// Delete the two partition dirs
DeleteFile(partitionFooSubDir),
DeleteFile(partitionBarSubDir),

AddTextFileData("{'value': 'keep6'}", partitionBarSubDir, tmp),
CheckAnswer(("keep2", "foo"), ("keep3", "foo"), ("keep4", "bar"), ("keep5", "bar"),
("keep6", "bar"))
Expand Down