Skip to content

[SPARK-18207][SQL] Fix a compilation error due to HashExpression.doGenCode #15745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kiszk wants to merge 13 commits into from
Closed

[SPARK-18207][SQL] Fix a compilation error due to HashExpression.doGenCode #15745

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
71c3284
initial commit
kiszk Nov 3, 2016
aa11c59
fix scala style error
kiszk Nov 3, 2016
24a6320
addressed review comments
kiszk Nov 5, 2016
3fdc813
delete empty line
kiszk Nov 5, 2016
049e477
fix test failures
kiszk Nov 6, 2016
6a57ba5
addressed review comments
kiszk Nov 7, 2016
e96742e
addressed review comments
kiszk Nov 7, 2016
2c405a1
addressed review comments
kiszk Nov 7, 2016
a2544df
addressed review comments
kiszk Nov 7, 2016
798fd85
addressed review comments
kiszk Nov 7, 2016
61504c3
addressed review comments
kiszk Nov 7, 2016
fa31521
fix compilation error
kiszk Nov 7, 2016
a2b2408
addressed review comments
kiszk Nov 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
addressed review comments
  • Loading branch information
@kiszk
kiszk committed Nov 8, 2016
commit a2b240808fc449c919c85ebe2eb840ca131ab8a4
6 changes: 4 additions & 2 deletions ...alyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HashExpressionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,13 @@ class HashExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
}
val murmur3HashExpr = Murmur3Hash(exprs, 42)
val murmur3HashPlan = GenerateMutableProjection.generate(Seq(murmur3HashExpr))
assert(murmur3HashPlan(wideRow).getInt(0) == 58499324)
val murmursHashEval = Murmur3Hash(exprs, 42).eval(wideRow)
assert(murmur3HashPlan(wideRow).getInt(0) == murmursHashEval)

val hiveHashExpr = HiveHash(exprs)
val hiveHashPlan = GenerateMutableProjection.generate(Seq(hiveHashExpr))
assert(hiveHashPlan(wideRow).getInt(0) == 117331003)
val hiveHashEval = HiveHash(exprs).eval(wideRow)
assert(hiveHashPlan(wideRow).getInt(0) == hiveHashEval)
}

private def testHash(inputSchema: StructType): Unit = {
Expand Down
1 change: 0 additions & 1 deletion sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1729,4 +1729,3 @@ class DataFrameSuite extends QueryTest with SharedSQLContext {
assert(df.filter($"array1" === $"array2").count() == 1)
}
}
Copy link
Contributor

@hvanhovell hvanhovell Nov 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to revert this change.

Copy link
Member Author

@kiszk kiszk Nov 7, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my typo. It is time for me to have to sleep.

Copy link
Contributor

@hvanhovell hvanhovell Nov 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. Happens to us all :)