Skip to content

[SPARK-18295][SQL] Make to_json function null safe (matching it to from_json) #15792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 2 commits into from
Closed

[SPARK-18295][SQL] Make to_json function null safe (matching it to from_json) #15792

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c53472
Make to_json expression/function null safe
HyukjinKwon Nov 7, 2016
ce0edda
Clean up the test
HyukjinKwon Nov 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Clean up the test
  • Loading branch information
@HyukjinKwon
HyukjinKwon committed Nov 7, 2016
commit ce0eddae4ee03002642c60cd21cc858ab4ae12a2
16 changes: 9 additions & 7 deletions sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,15 +142,17 @@ class JsonFunctionsSuite extends QueryTest with SharedSQLContext {
"Unable to convert column a of type calendarinterval to JSON."))
}

test("to_json and from_json roundtrip") {
val dfOne = Seq(Some(Tuple1(Tuple1(1))), None).toDF("a")
val readBackOne = dfOne.select(to_json($"a").as("b"))
.select(from_json($"b", dfOne.schema.head.dataType.asInstanceOf[StructType]))
test("roundtrip in to_json and from_json") {
val dfOne = Seq(Some(Tuple1(Tuple1(1))), None).toDF("struct")
val schemaOne = dfOne.schema(0).dataType.asInstanceOf[StructType]
val readBackOne = dfOne.select(to_json($"struct").as("json"))
.select(from_json($"json", schemaOne).as("struct"))
checkAnswer(dfOne, readBackOne)

val dfTwo = Seq(Some("""{"a":1}"""), None).toDF("value")
val schema = new StructType().add("a", IntegerType)
val readBackTwo = dfTwo.select(from_json($"value", schema).as("b")).select(to_json($"b"))
val dfTwo = Seq(Some("""{"a":1}"""), None).toDF("json")
val schemaTwo = new StructType().add("a", IntegerType)
val readBackTwo = dfTwo.select(from_json($"json", schemaTwo).as("struct"))
.select(to_json($"struct").as("json"))
checkAnswer(dfTwo, readBackTwo)
}
}