-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-18262][BUILD][SQL] JSON.org license is now CatX #15798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #68280 has finished for PR 15798 at commit
|
|
apologies if this is just a test run. If review comments are welcome currently, you should also update the top level NOTICE file to remove the blurb for org.json: |
|
Yeah just a test run right now ( |
|
Test build #68291 has finished for PR 15798 at commit
|
|
Hm, so indeed Jenkins tests find this is fine to exclude. I ran into local test failures that looked unrelated, even if they were persistent, so could be noise. My next step will be to make all the other license changes to make this a possibly mergeable change, just in case we do want to merge. |
|
SGTM. Thanks for doing this. |
…e it won't apply anymore
|
I removed the entry in |
|
That interpretation lines up with my understanding; we only need to recreate the portions of NOTICE that are applicable. |
|
Test build #68339 has finished for PR 15798 at commit
|
|
Test build #3419 has finished for PR 15798 at commit
|
|
Test build #3420 has finished for PR 15798 at commit
|
|
Test build #3421 has finished for PR 15798 at commit
|
|
Is this still WIP? |
|
I think it's mergeable. I'm slightly suspicious it was just this easy, but tests have passed. |
|
OK let's see. Merging in master/branch-2.1. |
## What changes were proposed in this pull request? Try excluding org.json:json from hive-exec dep as it's Cat X now. It may be the case that it's not used by the part of Hive Spark uses anyway. ## How was this patch tested? Existing tests Author: Sean Owen <[email protected]> Closes #15798 from srowen/SPARK-18262. (cherry picked from commit 16eaad9) Signed-off-by: Reynold Xin <[email protected]>
## What changes were proposed in this pull request? Try excluding org.json:json from hive-exec dep as it's Cat X now. It may be the case that it's not used by the part of Hive Spark uses anyway. ## How was this patch tested? Existing tests Author: Sean Owen <[email protected]> Closes apache#15798 from srowen/SPARK-18262.
What changes were proposed in this pull request?
Try excluding org.json:json from hive-exec dep as it's Cat X now. It may be the case that it's not used by the part of Hive Spark uses anyway.
How was this patch tested?
Existing tests