-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-18366][PYSPARK][ML] Add handleInvalid to Pyspark for QuantileDiscretizer and Bucketizer #15817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
[SPARK-18366][PYSPARK][ML] Add handleInvalid to Pyspark for QuantileDiscretizer and Bucketizer #15817
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0e41b36
add handleInvalid to QuantileDiscretizer
techaddict 3b5133c
fix lint issues
techaddict 20bfd9b
handleInvalid to Bucketizer
techaddict 1922472
fix lint error
techaddict b4720aa
Merge branch 'master' into SPARK-18366
techaddict 67a666f
Merge branch 'master' into SPARK-18366
techaddict 234d165
address comments
techaddict 0327d8a
commit
techaddict af0d3f2
use HasHandleInvalid
techaddict a8dc962
minor changes
techaddict 7ff8ad3
set Default
techaddict d589515
Merge branch 'master' into SPARK-18366
techaddict 08f8945
Merge branch 'master' into SPARK-18366
techaddict 36ecddb
Revert "use HasHandleInvalid"
techaddict 6687d3c
bring back handleInvalid
techaddict File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
add handleInvalid to QuantileDiscretizer
- Loading branch information
commit 0e41b36493fcb5eee5f342f694b0d2bc2a1e6c41
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We didn't add anything to the doctest of bucketizer. Actually, I think it would be nice in both places to set
handleInvalid='skip'and then add an invalid value to the example data. That way we can show what we mean by invalid and prove that it works.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea! adding