Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
160 changes: 0 additions & 160 deletions core/src/main/scala/org/apache/spark/SparkHadoopWriter.scala

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.spark.internal.io

import org.apache.hadoop.mapred._
import org.apache.hadoop.mapreduce.{TaskAttemptContext => NewTaskAttemptContext}

/**
* An [[FileCommitProtocol]] implementation backed by an underlying Hadoop OutputCommitter
* (from the old mapred API).
*
* Unlike Hadoop's OutputCommitter, this implementation is serializable.
*/
class HadoopMapRedCommitProtocol(jobId: String, path: String)
extends HadoopMapReduceCommitProtocol(jobId, path) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since most of the classes in mapred extend from mapreduce, we only have to override setupCommitter to make it support the OutputCommitter from mapred API. But the SparkHadoopWriter requires extensive refactoring.


override def setupCommitter(context: NewTaskAttemptContext): OutputCommitter = {
val config = context.getConfiguration.asInstanceOf[JobConf]
config.getOutputCommitter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a setupJob on the committer here ?

}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.spark.internal.io

import scala.reflect.ClassTag

import org.apache.hadoop.conf.Configuration
import org.apache.hadoop.mapred.JobConf
import org.apache.hadoop.mapreduce._

import org.apache.spark.util.{SerializableConfiguration, SerializableJobConf, Utils}

/**
* Interface for create output format/committer/writer used during saving an RDD using a Hadoop
* OutputFormat (both from the old mapred API and the new mapreduce API)
*
* Notes:
* 1. Implementations should throw [[IllegalArgumentException]] when wrong hadoop API is
* referenced;
* 2. Implementations must be serializable, as the instance instantiated on the driver
* will be used for tasks on executors;
* 3. Implementations should have a constructor with exactly one argument:
* (conf: SerializableConfiguration) or (conf: SerializableJobConf).
*/
abstract class HadoopWriteConfigUtil[K, V: ClassTag] extends Serializable {

// --------------------------------------------------------------------------
// Create JobContext/TaskAttemptContext
// --------------------------------------------------------------------------

def createJobContext(jobTrackerId: String, jobId: Int): JobContext

def createTaskAttemptContext(
jobTrackerId: String,
jobId: Int,
splitId: Int,
taskAttemptId: Int): TaskAttemptContext

// --------------------------------------------------------------------------
// Create committer
// --------------------------------------------------------------------------

def createCommitter(jobId: Int): HadoopMapReduceCommitProtocol

// --------------------------------------------------------------------------
// Create writer
// --------------------------------------------------------------------------

def initWriter(taskContext: TaskAttemptContext, splitId: Int): Unit

def write(pair: (K, V)): Unit

def closeWriter(taskContext: TaskAttemptContext): Unit

// --------------------------------------------------------------------------
// Create OutputFormat
// --------------------------------------------------------------------------

def initOutputFormat(jobContext: JobContext): Unit

// --------------------------------------------------------------------------
// Verify hadoop config
// --------------------------------------------------------------------------

def assertConf(): Unit

def checkOutputSpecs(jobContext: JobContext): Unit

}
Loading