Skip to content

Conversation

@srowen
Copy link
Member

@srowen srowen commented Nov 12, 2016

What changes were proposed in this pull request?

Avoid reporting null/-1 file / line number in call sites if encountering StackTraceElement without this info

How was this patch tested?

Existing tests

@SparkQA
Copy link

SparkQA commented Nov 12, 2016

Test build #68561 has finished for PR 15862 at commit 6eeaba7.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Retest this please.

@SparkQA
Copy link

SparkQA commented Nov 12, 2016

Test build #68568 has finished for PR 15862 at commit 6eeaba7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sarutak
Copy link
Member

sarutak commented Nov 14, 2016

LGTM

asfgit pushed a commit that referenced this pull request Nov 14, 2016
… call site info

## What changes were proposed in this pull request?

Avoid reporting null/-1 file / line number in call sites if encountering StackTraceElement without this info

## How was this patch tested?

Existing tests

Author: Sean Owen <[email protected]>

Closes #15862 from srowen/SPARK-18382.

(cherry picked from commit f95b124)
Signed-off-by: Kousuke Saruta <[email protected]>
@asfgit asfgit closed this in f95b124 Nov 14, 2016
asfgit pushed a commit that referenced this pull request Nov 14, 2016
… call site info

## What changes were proposed in this pull request?

Avoid reporting null/-1 file / line number in call sites if encountering StackTraceElement without this info

## How was this patch tested?

Existing tests

Author: Sean Owen <[email protected]>

Closes #15862 from srowen/SPARK-18382.

(cherry picked from commit f95b124)
Signed-off-by: Kousuke Saruta <[email protected]>
@sarutak
Copy link
Member

sarutak commented Nov 14, 2016

Merging into master/branch-2.0/branch-2.1. Thanks.

@srowen srowen deleted the SPARK-18382 branch November 14, 2016 11:11
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
… call site info

## What changes were proposed in this pull request?

Avoid reporting null/-1 file / line number in call sites if encountering StackTraceElement without this info

## How was this patch tested?

Existing tests

Author: Sean Owen <[email protected]>

Closes apache#15862 from srowen/SPARK-18382.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants