[SPARK-18300][SQL] Do not apply foldable propagation with expand as a child [BRANCH-2.0] #15892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @gatorsmile |
Member
|
LGTM |
|
Test build #68677 has finished for PR 15892 at commit
|
Contributor
|
Merging in. Can you close the ticket? |
asfgit
pushed a commit
that referenced
this pull request
Nov 16, 2016
… child [BRANCH-2.0] ## What changes were proposed in this pull request? The `FoldablePropagation` optimizer rule, pulls foldable values out from under an `Expand`. This breaks the `Expand` in two ways: - It rewrites the output attributes of the `Expand`. We explicitly define output attributes for `Expand`, these are (unfortunately) considered as part of the expressions of the `Expand` and can be rewritten. - Expand can actually change the column (it will typically re-use the attributes or the underlying plan). This means that we cannot safely propagate the expressions from under an `Expand`. This PR fixes this and (hopefully) other issues by explicitly whitelisting allowed operators. This is a backport of #15857 ## How was this patch tested? Added tests to `FoldablePropagationSuite` and to `SQLQueryTestSuite`. Author: Herman van Hovell <[email protected]> Closes #15892 from hvanhovell/SPARK-18300-branch-2.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
FoldablePropagationoptimizer rule, pulls foldable values out from under anExpand. This breaks theExpandin two ways:Expand. We explicitly define output attributes forExpand, these are (unfortunately) considered as part of the expressions of theExpandand can be rewritten.Expand.This PR fixes this and (hopefully) other issues by explicitly whitelisting allowed operators.
This is a backport of #15857
How was this patch tested?
Added tests to
FoldablePropagationSuiteand toSQLQueryTestSuite.