[SPARK-18477][SS]Enable interrupts for HDFS in HDFSMetadataLog #15911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @tdas |
|
Test build #68738 has finished for PR 15911 at commit
|
Contributor
|
LGTM. Merging to master, 2.1, and 2.0 |
asfgit
pushed a commit
that referenced
this pull request
Nov 19, 2016
## What changes were proposed in this pull request? HDFS `write` may just hang until timeout if some network error happens. It's better to enable interrupts to allow stopping the query fast on HDFS. This PR just changes the logic to only disable interrupts for local file system, as HADOOP-10622 only happens for local file system. ## How was this patch tested? Jenkins Author: Shixiong Zhu <[email protected]> Closes #15911 from zsxwing/interrupt-on-dfs. (cherry picked from commit e5f5c29) Signed-off-by: Tathagata Das <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Nov 19, 2016
## What changes were proposed in this pull request? HDFS `write` may just hang until timeout if some network error happens. It's better to enable interrupts to allow stopping the query fast on HDFS. This PR just changes the logic to only disable interrupts for local file system, as HADOOP-10622 only happens for local file system. ## How was this patch tested? Jenkins Author: Shixiong Zhu <[email protected]> Closes #15911 from zsxwing/interrupt-on-dfs. (cherry picked from commit e5f5c29) Signed-off-by: Tathagata Das <[email protected]>
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? HDFS `write` may just hang until timeout if some network error happens. It's better to enable interrupts to allow stopping the query fast on HDFS. This PR just changes the logic to only disable interrupts for local file system, as HADOOP-10622 only happens for local file system. ## How was this patch tested? Jenkins Author: Shixiong Zhu <[email protected]> Closes apache#15911 from zsxwing/interrupt-on-dfs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDFS
writemay just hang until timeout if some network error happens. It's better to enable interrupts to allow stopping the query fast on HDFS.This PR just changes the logic to only disable interrupts for local file system, as HADOOP-10622 only happens for local file system.
How was this patch tested?
Jenkins