[SPARK-18520][ML] Add missing setXXXCol methods for BisectingKMeansModel and GaussianMixtureModel #15957
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #68921 has finished for PR 15957 at commit
|
Member
|
CC @jkbradley per your message today in case this should really be in for 2.1 |
Contributor
|
These look like really basic additions of things we simply forgot to expose so I think we can include it between RCs. Also LGTM. |
Contributor
|
LGTM, just like @holdenk said, this is very basic change. So I'll merge it into master and branch-2.1. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Nov 24, 2016
…del and GaussianMixtureModel ## What changes were proposed in this pull request? add `setFeaturesCol` and `setPredictionCol` for BiKModel and GMModel add `setProbabilityCol` for GMModel ## How was this patch tested? existing tests Author: Zheng RuiFeng <[email protected]> Closes #15957 from zhengruifeng/bikm_set. (cherry picked from commit 2dfabec) Signed-off-by: Yanbo Liang <[email protected]>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 2, 2016
…del and GaussianMixtureModel ## What changes were proposed in this pull request? add `setFeaturesCol` and `setPredictionCol` for BiKModel and GMModel add `setProbabilityCol` for GMModel ## How was this patch tested? existing tests Author: Zheng RuiFeng <[email protected]> Closes apache#15957 from zhengruifeng/bikm_set.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…del and GaussianMixtureModel ## What changes were proposed in this pull request? add `setFeaturesCol` and `setPredictionCol` for BiKModel and GMModel add `setProbabilityCol` for GMModel ## How was this patch tested? existing tests Author: Zheng RuiFeng <[email protected]> Closes apache#15957 from zhengruifeng/bikm_set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add
setFeaturesColandsetPredictionColfor BiKModel and GMModeladd
setProbabilityColfor GMModelHow was this patch tested?
existing tests