[SPARK-18058][SQL][TRIVIAL] Use dataType.sameResult(...) instead equality on asNullable datatypes #16041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #69252 has finished for PR 16041 at commit
|
Contributor
|
Merging in master/branch-2.1. |
asfgit
pushed a commit
that referenced
this pull request
Nov 29, 2016
…lity on asNullable datatypes ## What changes were proposed in this pull request? This is absolutely minor. PR #15595 uses `dt1.asNullable == dt2.asNullable` expressions in a few places. It is however more efficient to call `dt1.sameType(dt2)`. I have replaced every instance of the first pattern with the second pattern (3/5 were introduced by #15595). ## How was this patch tested? Existing tests. Author: Herman van Hovell <[email protected]> Closes #16041 from hvanhovell/SPARK-18058. (cherry picked from commit d449988) Signed-off-by: Reynold Xin <[email protected]>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 2, 2016
…lity on asNullable datatypes ## What changes were proposed in this pull request? This is absolutely minor. PR apache#15595 uses `dt1.asNullable == dt2.asNullable` expressions in a few places. It is however more efficient to call `dt1.sameType(dt2)`. I have replaced every instance of the first pattern with the second pattern (3/5 were introduced by apache#15595). ## How was this patch tested? Existing tests. Author: Herman van Hovell <[email protected]> Closes apache#16041 from hvanhovell/SPARK-18058.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…lity on asNullable datatypes ## What changes were proposed in this pull request? This is absolutely minor. PR apache#15595 uses `dt1.asNullable == dt2.asNullable` expressions in a few places. It is however more efficient to call `dt1.sameType(dt2)`. I have replaced every instance of the first pattern with the second pattern (3/5 were introduced by apache#15595). ## How was this patch tested? Existing tests. Author: Herman van Hovell <[email protected]> Closes apache#16041 from hvanhovell/SPARK-18058.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is absolutely minor. PR #15595 uses
dt1.asNullable == dt2.asNullableexpressions in a few places. It is however more efficient to calldt1.sameType(dt2). I have replaced every instance of the first pattern with the second pattern (3/5 were introduced by #15595).How was this patch tested?
Existing tests.