Skip to content

[SPARK-17897] [SQL] Fixed IsNotNull Constraint Inference Rule #16067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gatorsmile wants to merge 6 commits into from
Closed

[SPARK-17897] [SQL] Fixed IsNotNull Constraint Inference Rule #16067

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
33c10a0
fix.
gatorsmile Nov 29, 2016
025632a
fix.
gatorsmile Nov 29, 2016
0722ae5
improve the comments.
gatorsmile Nov 29, 2016
f693040
rename the func
gatorsmile Nov 29, 2016
a835f80
address comments.
gatorsmile Nov 30, 2016
54c0dd1
address comments.
gatorsmile Nov 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix.
  • Loading branch information
@gatorsmile
gatorsmile committed Nov 29, 2016
commit 33c10a0994c9802df901f211e1f28c52e34df27f
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ trait NamedExpression extends Expression {
}
}

abstract class Attribute extends LeafExpression with NamedExpression with NullIntolerant {
abstract class Attribute extends LeafExpression with NamedExpression {

override def references: AttributeSet = AttributeSet(this)

Expand Down
5 changes: 5 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1720,6 +1720,11 @@ class DataFrameSuite extends QueryTest with SharedSQLContext {
dates.intersect(widenTypedRows).collect()
}

test("SPARK-17897: Attribute is not NullIntolerant") {
val data = Seq[java.lang.Integer](1, null).toDF("key")
checkAnswer(data.filter("not key is not null"), Row(null))
}

test("SPARK-18070 binary operator should not consider nullability when comparing input types") {
val rows = Seq(Row(Seq(1), Seq(1)))
val schema = new StructType()
Expand Down