Skip to content

[SPARK-18091] [SQL] [BACKPORT-1.6] Deep if expressions cause Generated SpecificUnsafeProjection code to exceed JVM code size limit #16146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kapilsingh5050 wants to merge 4 commits into from
Closed

[SPARK-18091] [SQL] [BACKPORT-1.6] Deep if expressions cause Generated SpecificUnsafeProjection code to exceed JVM code size limit #16146

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8672343
Fixed If expression code generation to never generate code large enou…
Dec 5, 2016
caafdc6
[SPARK-14578] [SQL] [BACKPORT-1.6] Fix codegen for CreateExternalRow …
Apr 13, 2016
b60e788
[SQL][MINOR] simplify a test to fix the maven tests
cloud-fan Dec 11, 2016
708c847
[minor] Fixed unit test as per 1.6
Dec 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[minor] Fixed unit test as per 1.6
  • Loading branch information
Kapil Singh committed Dec 15, 2016
commit 708c847bd86ded2f58ec0ff05424cc437aac99b5
4 changes: 2 additions & 2 deletions ...talyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGenerationSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,12 @@ class CodeGenerationSuite extends SparkFunSuite with ExpressionEvalHelper {

test("SPARK-18091: split large if expressions into blocks due to JVM code size limit") {
var strExpr: Expression = Literal("abc")
for (_ <- 1 to 150) {
for (_ <- 1 to 100) {
strExpr = Decode(Encode(strExpr, "utf-8"), "utf-8")
}

val expressions = Seq(If(EqualTo(strExpr, strExpr), strExpr, strExpr))
val plan = GenerateMutableProjection.generate(expressions)
val plan = GenerateMutableProjection.generate(expressions)()
val actual = plan(null).toSeq(expressions.map(_.dataType))
val expected = Seq(UTF8String.fromString("abc"))

Expand Down