Skip to content

Conversation

@liancheng
Copy link
Contributor

@liancheng liancheng commented Dec 6, 2016

What changes were proposed in this pull request?

Currently, the full console output page of a Spark Jenkins PR build can be as large as several megabytes. It takes a relatively long time to load and may even freeze the browser for quite a while.

This PR makes the build script to post the test report page link to GitHub instead. The test report page is way more concise and is usually the first page I'd like to check when investigating a Jenkins build failure.

Note that for builds that a test report is not available (ongoing builds and builds that fail before test execution), the test report link automatically redirects to the build page.

How was this patch tested?

N/A.

@srowen
Copy link
Member

srowen commented Dec 6, 2016

It might not be exactly the same thing, but I remember we changed something like this in the opposite way -- to link straight to the full output since typically you need that to debug a failure, and loading the brief page is just an extra hop.

I don't feel strongly about it, just dumping an anecdote from the back of my brain.

@SparkQA
Copy link

SparkQA commented Dec 6, 2016

Test build #69703 has finished for PR 16163 at commit 6aa9f34.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@liancheng
Copy link
Contributor Author

@srowen Thanks. I sent this one because the consoleFull page frequently freezes my browser these days, not mentioning viewing Jenkins build results via mobile phone...

@rxin
Copy link
Contributor

rxin commented Dec 14, 2016

Alright let's try this ... Merging in master/branch-2.1.

@asfgit asfgit closed this in ba4aab9 Dec 14, 2016
asfgit pushed a commit that referenced this pull request Dec 14, 2016
…le output page to GitHub

## What changes were proposed in this pull request?

Currently, the full console output page of a Spark Jenkins PR build can be as large as several megabytes. It takes a relatively long time to load and may even freeze the browser for quite a while.

This PR makes the build script to post the test report page link to GitHub instead. The test report page is way more concise and is usually the first page I'd like to check when investigating a Jenkins build failure.

Note that for builds that a test report is not available (ongoing builds and builds that fail before test execution), the test report link automatically redirects to the build page.

## How was this patch tested?

N/A.

Author: Cheng Lian <[email protected]>

Closes #16163 from liancheng/jenkins-test-report.

(cherry picked from commit ba4aab9)
Signed-off-by: Reynold Xin <[email protected]>
robert3005 pushed a commit to palantir/spark that referenced this pull request Dec 15, 2016
…le output page to GitHub

## What changes were proposed in this pull request?

Currently, the full console output page of a Spark Jenkins PR build can be as large as several megabytes. It takes a relatively long time to load and may even freeze the browser for quite a while.

This PR makes the build script to post the test report page link to GitHub instead. The test report page is way more concise and is usually the first page I'd like to check when investigating a Jenkins build failure.

Note that for builds that a test report is not available (ongoing builds and builds that fail before test execution), the test report link automatically redirects to the build page.

## How was this patch tested?

N/A.

Author: Cheng Lian <[email protected]>

Closes apache#16163 from liancheng/jenkins-test-report.
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
…le output page to GitHub

## What changes were proposed in this pull request?

Currently, the full console output page of a Spark Jenkins PR build can be as large as several megabytes. It takes a relatively long time to load and may even freeze the browser for quite a while.

This PR makes the build script to post the test report page link to GitHub instead. The test report page is way more concise and is usually the first page I'd like to check when investigating a Jenkins build failure.

Note that for builds that a test report is not available (ongoing builds and builds that fail before test execution), the test report link automatically redirects to the build page.

## How was this patch tested?

N/A.

Author: Cheng Lian <[email protected]>

Closes apache#16163 from liancheng/jenkins-test-report.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants