[SPARK-18856][SQL] non-empty partitioned table should not report zero size #16280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
cloud-fan
commented
Dec 14, 2016
| className = table.provider.get, | ||
| options = table.storage.properties ++ pathOption) | ||
| options = table.storage.properties ++ pathOption, | ||
| catalogTable = Some(simpleCatalogRelation.metadata)) |
Contributor
Author
There was a problem hiding this comment.
Previously we will always use InMemoryFileIndex because we don't pass the catalog table to DataSource...
Contributor
There was a problem hiding this comment.
Any way to catch this in a test? Presumably this would have caused all the files to be scanned.
Contributor
Author
There was a problem hiding this comment.
oh i know why. The InMemoryExternalCatalog hasn't implemented all the interfaces(e.g. some partition related ones), so we did it intentionally.
|
Test build #70130 has finished for PR 16280 at commit
|
ericl
approved these changes
Dec 14, 2016
|
Test build #70167 has finished for PR 16280 at commit
|
Contributor
|
Merging in master/branch-2.1. |
asfgit
pushed a commit
that referenced
this pull request
Dec 15, 2016
… size ## What changes were proposed in this pull request? In `DataSource`, if the table is not analyzed, we will use 0 as the default value for table size. This is dangerous, we may broadcast a large table and cause OOM. We should use `defaultSizeInBytes` instead. ## How was this patch tested? new regression test Author: Wenchen Fan <[email protected]> Closes #16280 from cloud-fan/bug. (cherry picked from commit d6f11a1) Signed-off-by: Reynold Xin <[email protected]>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 15, 2016
… size ## What changes were proposed in this pull request? In `DataSource`, if the table is not analyzed, we will use 0 as the default value for table size. This is dangerous, we may broadcast a large table and cause OOM. We should use `defaultSizeInBytes` instead. ## How was this patch tested? new regression test Author: Wenchen Fan <[email protected]> Closes apache#16280 from cloud-fan/bug.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
… size ## What changes were proposed in this pull request? In `DataSource`, if the table is not analyzed, we will use 0 as the default value for table size. This is dangerous, we may broadcast a large table and cause OOM. We should use `defaultSizeInBytes` instead. ## How was this patch tested? new regression test Author: Wenchen Fan <[email protected]> Closes apache#16280 from cloud-fan/bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In
DataSource, if the table is not analyzed, we will use 0 as the default value for table size. This is dangerous, we may broadcast a large table and cause OOM. We should usedefaultSizeInBytesinstead.How was this patch tested?
new regression test