[SPARK-18795][ML][SPARKR][DOC] Added KSTest section to SparkR vignettes #16283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
felixcheung
reviewed
Dec 14, 2016
R/pkg/vignettes/sparkr-vignettes.Rmd
Outdated
| afMean <- afStats[1] | ||
| afStd <- afStats[2] | ||
| test <- spark.kstest(df, "Armed_Forces", "norm", c(afMean,afStd)) |
Member
There was a problem hiding this comment.
nit, space in c(afMean, afStd) for style
Member
|
LGTM, minor style comment |
Member
Author
|
OK thanks! I'll merge after tests pass. |
|
Test build #70147 has finished for PR 16283 at commit
|
Member
Author
|
Merging with master and branch-2.1 |
asfgit
pushed a commit
that referenced
this pull request
Dec 14, 2016
## What changes were proposed in this pull request? Added short section for KSTest. Also added logreg model to list of ML models in vignette. (This will be reorganized under SPARK-18849)  ## How was this patch tested? Manually tested example locally. Built vignettes locally. Author: Joseph K. Bradley <[email protected]> Closes #16283 from jkbradley/ksTest-vignette. (cherry picked from commit 7862742) Signed-off-by: Joseph K. Bradley <[email protected]>
|
Test build #70150 has finished for PR 16283 at commit
|
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 15, 2016
## What changes were proposed in this pull request? Added short section for KSTest. Also added logreg model to list of ML models in vignette. (This will be reorganized under SPARK-18849)  ## How was this patch tested? Manually tested example locally. Built vignettes locally. Author: Joseph K. Bradley <[email protected]> Closes apache#16283 from jkbradley/ksTest-vignette.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? Added short section for KSTest. Also added logreg model to list of ML models in vignette. (This will be reorganized under SPARK-18849)  ## How was this patch tested? Manually tested example locally. Built vignettes locally. Author: Joseph K. Bradley <[email protected]> Closes apache#16283 from jkbradley/ksTest-vignette.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added short section for KSTest.
Also added logreg model to list of ML models in vignette. (This will be reorganized under SPARK-18849)
How was this patch tested?
Manually tested example locally.
Built vignettes locally.