[SPARK-18870] Disallowed Distinct Aggregations on Streaming Datasets #16289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #70170 has finished for PR 16289 at commit
|
rxin
reviewed
Dec 15, 2016
| } | ||
| throwErrorIf( | ||
| child.isStreaming && distinctAggExprs.nonEmpty, | ||
| "Distinct aggregations are not supported on streaming DataFrames/Datasets, unless" + |
Contributor
There was a problem hiding this comment.
you need an extra space here. I'd also recommend users using approximate distinct.
|
Test build #70183 has started for PR 16289 at commit |
Contributor
Author
|
jenkins test this please |
|
Test build #70184 has finished for PR 16289 at commit
|
|
Test build #3498 has finished for PR 16289 at commit
|
Contributor
|
LGTM |
Contributor
Author
|
Merging to 2.1 and master |
asfgit
pushed a commit
that referenced
this pull request
Dec 15, 2016
## What changes were proposed in this pull request? Check whether Aggregation operators on a streaming subplan have aggregate expressions with isDistinct = true. ## How was this patch tested? Added unit test Author: Tathagata Das <[email protected]> Closes #16289 from tdas/SPARK-18870. (cherry picked from commit 4f7292c) Signed-off-by: Tathagata Das <[email protected]>
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? Check whether Aggregation operators on a streaming subplan have aggregate expressions with isDistinct = true. ## How was this patch tested? Added unit test Author: Tathagata Das <[email protected]> Closes apache#16289 from tdas/SPARK-18870.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Check whether Aggregation operators on a streaming subplan have aggregate expressions with isDistinct = true.
How was this patch tested?
Added unit test