Skip to content

Conversation

@shivaram
Copy link
Contributor

What changes were proposed in this pull request?

For release builds the R_PACKAGE_VERSION and VERSION are the same (e.g., 2.1.0). Thus cp throws an error which causes the build to fail.

How was this patch tested?

Manually by executing the following script

set -o pipefail
set -e
set -x

touch a

R_PACKAGE_VERSION=2.1.0
VERSION=2.1.0

if [ "$R_PACKAGE_VERSION" != "$VERSION" ]; then
  cp a a
fi

@shivaram
Copy link
Contributor Author

cc @rxin

@felixcheung
Copy link
Member

@felixcheung
Copy link
Member

I found an issue with snapshot build just now - R CMD check doesn't handle the -SNAPSHOT part of the file name in SparkR_*tar.gz. Since it's only an issue with SNAPSHOT build I'll open a PR separately.

@shivaram
Copy link
Contributor Author

Ah I see - yes - using mv is a simpler option - BTW when do we run R CMD check ? Is this for say when users download the tar.gz and run it ? (We can move this discussion to the JIRA)

@rxin
Copy link
Contributor

rxin commented Dec 16, 2016

Merging in master/branch-2.1.

asfgit pushed a commit that referenced this pull request Dec 16, 2016
## What changes were proposed in this pull request?

For release builds the R_PACKAGE_VERSION and VERSION are the same (e.g., 2.1.0). Thus `cp` throws an error which causes the build to fail.

## How was this patch tested?

Manually by executing the following script
```
set -o pipefail
set -e
set -x

touch a

R_PACKAGE_VERSION=2.1.0
VERSION=2.1.0

if [ "$R_PACKAGE_VERSION" != "$VERSION" ]; then
  cp a a
fi
```

Author: Shivaram Venkataraman <[email protected]>

Closes #16299 from shivaram/sparkr-cp-fix.

(cherry picked from commit 9634018)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in 9634018 Dec 16, 2016
@SparkQA
Copy link

SparkQA commented Dec 16, 2016

Test build #70220 has finished for PR 16299 at commit fcc8265.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 16, 2016

Test build #70222 has finished for PR 16299 at commit 95ac227.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
## What changes were proposed in this pull request?

For release builds the R_PACKAGE_VERSION and VERSION are the same (e.g., 2.1.0). Thus `cp` throws an error which causes the build to fail.

## How was this patch tested?

Manually by executing the following script
```
set -o pipefail
set -e
set -x

touch a

R_PACKAGE_VERSION=2.1.0
VERSION=2.1.0

if [ "$R_PACKAGE_VERSION" != "$VERSION" ]; then
  cp a a
fi
```

Author: Shivaram Venkataraman <[email protected]>

Closes apache#16299 from shivaram/sparkr-cp-fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants