-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-18871][SQL] New test cases for IN/NOT IN subquery #16337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
3b44c59
18b4a31
4f4d1c8
f5f0cbe
d8b2edb
196b6c6
f37a01e
bb5b01f
bde5820
5f7cd96
893a49a
4bbe1fd
b2dd795
8c3e5da
a0eaa40
d03c940
d728d5e
ea104dd
6ab1215
0c56653
d7a1874
85d3500
c056f91
0b8189d
c2ea31d
a2d3056
39e5648
b9370a3
01224a4
d05d39a
ee6ed88
db19296
2e399d9
0ef59bc
6fad85f
5525dff
63715e4
a084410
cdfb1ad
753d7fe
b6e5b97
7ca65ec
7165105
32dbd46
ee1e14e
c2ca009
9c584fb
1c1900a
7c129d9
895bb35
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -73,13 +73,13 @@ select t1a, t1b from t1 where t1c in (select t2b from t2 where t2a in | |
| -- simple select for NOT IN | ||
| -- TC 01.07 | ||
| select distinct(t1a), t1b, t1h from t1 where t1a not in (select t2a from t2); | ||
| -- TC 01.08 | ||
| select t1d, t1h, t1i from t1 where t1d not in (select t2d from t2 where t2h > t1h or t2i > t1i); | ||
| -- TC 01.08, comment out pending on SPARK-18966 | ||
| --select t1d, t1h, t1i from t1 where t1d not in (select t2d from t2 where t2h > t1h or t2i > t1i); | ||
| -- TC 01.09 | ||
| select distinct(t1a), t1b from t1 where t1b not in (select t2b from t2 where t1a < t2a and t2b > 8); | ||
| -- TC 01.10 | ||
| select t1a, t1b from t1 where t1c not in (select t2b from t2 where t2a not in | ||
| (select t3a from t3 where t2c = t3c and t2b is NULL)); | ||
| -- TC 01.10, comment out pending on SPARK-18966 | ||
| --select t1a, t1b from t1 where t1c not in (select t2b from t2 where t2a not in | ||
| -- (select t3a from t3 where t2c = t3c and t2b is NULL)); | ||
|
||
| -- TC 01.11 | ||
| select t1a, t1b from t1 where t1h not in (select t2h from t2 where t2a = t1a) and t1b not in ( | ||
| (select min(t3b) from t3 where t3d = t1d)); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test suite is only for positive cases, right? The above two test cases are negative cases. The negative cases can be added with the other negative cases. Right? We can put these two cases in the JIRA-18863.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will enable these two test cases once the problem is fixed. They remain here to demonstrate the test coverage of IN/NOT IN subquery. At this point, I have only done an initial investigation on SPARK-18863. Once the investigation is confirmed that these two cases have the same root cause as the one in 18863, they will be cross-referenced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two test cases will not be part of this test suite, right? So far, no negative cases are added to this test suite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, so we can add these test cases back when deliver the fixes as you mentioned below? I will put these test case into the JIRA-18863. Thanks.